Skip to content

Build Corrections and Optimisation and Spelling Corrections #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Build Corrections and Optimisation and Spelling Corrections #957

wants to merge 24 commits into from

Conversation

uni-paul-taylor2
Copy link

@uni-paul-taylor2 uni-paul-taylor2 commented Feb 6, 2025 •
edited
Loading

Spelling

  • Renamed a specific "REAMDME.md" to "README.md"
  • Corrected 2 instances of "Dowload" to "Download"
  • Corrected an instance of "leat" to "least"

Build Speed Optimisation

  • Used $(nproc) which would be the device's number of processors, to use them instead of just one
  • Considered switching from make to ninja which are build systems which both work in every CMake project yet ninja is known to be faster for medium and larger codebases, however the time difference was something like 7 seconds over 30 minutes which is insignificant

Extra (Todo)

  • added a script to download, build and install project dependencies

@uni-paul-taylor2
Copy link
Author

okay I looked for the option to turn to draft (closing it was an accident)

@uni-paul-taylor2 uni-paul-taylor2 marked this pull request as draft February 17, 2025 12:36
@uni-paul-taylor2
C++14 used instead of C++11
cbcaa64 
CMAKE_CXX_STANDARD was not set however since it was not set for 11 previously and it is unknown if setting a standard will break anything for now
if the standard was to be set it would look like:
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
@uni-paul-taylor2
Documentation Updated
e6a43a1
@uni-paul-taylor2
rename REAMDE.md to README.md in examples
118c7f1
@uni-paul-taylor2
changed flag from COMPILEDWITHC11 to COMPILEDWITHC14
0a6b08d
@uni-paul-taylor2
changed Examples_old flags from COMPILEDWITHC11 to COMPILEDWITHC14
321cb0a
@uni-paul-taylor2
Copy link
Author

The build finally completes and the following issues are solved as well

  • 433
  • 458 is closed even though the solution was never implemented in the repository

@uni-paul-taylor2 uni-paul-taylor2 changed the title Build Speed Optimisation and Spelling Error Corrections Build Working and Build Speed Optimisation and Spelling Error Corrections Feb 23, 2025
@uni-paul-taylor2 uni-paul-taylor2 changed the title Build Working and Build Speed Optimisation and Spelling Error Corrections Build Corrections and Optimisation and Spelling Corrections Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uni-paul-taylor2