Skip to content

Fix coverage generation #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

Fix coverage generation #142

merged 1 commit into from
Apr 18, 2022

Conversation

antipeon
Copy link
Collaborator

@antipeon antipeon commented Apr 7, 2022

No description provided.

@antipeon
Copy link
Collaborator Author

in bin target was .o file: Screenshot (70)
now test executable: Screenshot (68)
and coverage is shown: Screenshot (69)

@antipeon
Copy link
Collaborator Author

for .so files remains unchanged:
Screenshot (71)
coverage was already shown:
Screenshot (72)

ladisgin
ladisgin requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@ladisgin ladisgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash commits

server/src/printers/NativeMakefilePrinter.cpp Outdated

fs::path coverageInfoBin = sharedOutput.value();
if (!Paths::isLibraryFile(coverageInfoBin))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use same style as other file. Move open brackets on same line as if statement.

@antipeon antipeon force-pushed the fix-coverage-generation branch from 62b10c7 to 48ec07f Compare April 15, 2022 13:16
@antipeon antipeon merged commit db0fdcf into main Apr 18, 2022
@antipeon antipeon deleted the fix-coverage-generation branch April 18, 2022 08:49
@antipeon antipeon linked an issue Apr 26, 2022 that may be closed by this pull request
tests can be generated, but there is no coverage generated when run the test #110
Open
ladisgin added a commit that referenced this pull request Sep 7, 2023
@ladisgin
Remove gradle cache after build clion plugin
47d0457 
Merge pull request #185 from willzhang4a58/master

fix bug: CHECK_EQ_F(int64, int64)
Apply clang-format --style=Google
Add `${CMAKE_CURRENT_SOURCE_DIR}` to header path - issue #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladisgin ladisgin ladisgin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests can be generated, but there is no coverage generated when run the test
2 participants
@antipeon @ladisgin