Skip to content

supported examples added #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged

supported examples added #339

merged 1 commit into from
Aug 5, 2022

Conversation

belous-dp
Copy link
Collaborator

No description provided.

@belous-dp belous-dp requested a review from Lana243 July 23, 2022 17:40
@@ -1,27 +1,10 @@
#include "multi_arrays.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split to 2 files

@@ -1,49 +0,0 @@
static int x = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't delete this file just create issue with regression label

@belous-dp belous-dp force-pushed the belous-dp/examples branch from 31896e8 to 7f5642e Compare July 25, 2022 15:19
@belous-dp belous-dp requested a review from ladisgin July 25, 2022 15:20
return 0;
}

unsigned int do_while_loop_unsigned_correct(unsigned int n) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you decide to leave this function, add it to header, please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@belous-dp belous-dp force-pushed the belous-dp/examples branch 2 times, most recently from 868ace2 to c766e95 Compare July 28, 2022 14:53
@belous-dp belous-dp requested a review from Lana243 July 28, 2022 14:54
Copy link
Collaborator

@Lana243 Lana243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a single empty line at the end of each file. Also see comments in unsupported examples PR and move some examples here

@belous-dp belous-dp force-pushed the belous-dp/examples branch from c766e95 to 8782e60 Compare August 1, 2022 16:31
@belous-dp
Copy link
Collaborator Author

Please add a single empty line at the end of each file. Also see comments in unsupported examples PR and move some examples here

There's NL at the end of each file, github just doesn't show them. pseudo_random examples moved.

@belous-dp belous-dp requested a review from Lana243 August 2, 2022 10:45
Copy link
Collaborator

@Lana243 Lana243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "loops.h"
#include <stdbool.h>

unsigned int while_loop_unsigned_correct(unsigned int n) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please, rename this function without correct suffix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@belous-dp
Copy link
Collaborator Author

Add example with static variable from unsupported repo: UnitTestBot/UTBotCpp-unsupported#1 (review)

examples added

@belous-dp belous-dp force-pushed the belous-dp/examples branch from 8782e60 to 20c0ce6 Compare August 5, 2022 10:07
@belous-dp belous-dp requested a review from Lana243 August 5, 2022 10:07
Copy link
Collaborator

@Lana243 Lana243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@belous-dp belous-dp force-pushed the belous-dp/examples branch from 20c0ce6 to 9ac98b2 Compare August 5, 2022 11:37
@belous-dp belous-dp merged commit 0a32aa7 into main Aug 5, 2022
@sava-cska sava-cska deleted the belous-dp/examples branch September 1, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants