Use proper disposable for connection to message bus #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vol0n
commented
Aug 19, 2022
| @@ -23,7 +22,7 @@ class ClientManager(val project: Project): Disposable { | |||
| } | |||
|
|
|||
| private fun subscribeToEvents() { | |||
| with(ApplicationManager.getApplication().messageBus.connect()) { | |||
There was a problem hiding this comment.
Here was the cause for exception: after closing project this listeners was not disposed, because it had application lifetime
alexey-utkin
approved these changes
Aug 22, 2022
clion-plugin/src/test/kotlin/org/utbot/cpp/clion/plugin/BaseGenerationTestCase.kt
Outdated
Show resolved
Hide resolved
clion-plugin/src/test/kotlin/org/utbot/cpp/clion/plugin/BaseGenerationTestCase.kt
Show resolved
Hide resolved
...in/src/main/kotlin/org/utbot/cpp/clion/plugin/ui/targetsToolWindow/UTBotTargetsController.kt
Outdated
Show resolved
Hide resolved
alexey-utkin
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #389
ClientLogger already disposedwhen opening multiple projects or opening one project several times. The cause wasApplicationManager.getApplication().messageBus.connect()inClientManagerinstead ofproject.messageBus.connect()messageBus.syncPublishertoif (!messageBus.isDisposed()) messageBus.syncPublisher. Not related to issue, but it should be this way