fix: show run icons only for files in tests directory #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vol0n
force-pushed
the
vol0n/fix_run_icons_location
branch
from
1a38ec1 to
01f44b4
Compare
| @@ -51,7 +55,13 @@ class UTBotTestRunLineMarkerProvider : LineMarkerProvider { | |||
| return UTBotRunWithCoverageLineMarkerInfo(element, message, getStatusIcon(element)) | |||
| } | |||
|
|
|||
| private fun getStatusIcon(element: PsiElement): Icon { | |||
| private fun isElementInTestFileGeneratedByUTBot(element: PsiElement) = | |||
| element.containingFile.virtualFile.localPath.let { | |||
There was a problem hiding this comment.
Is this the same way we check the 'test' status in VSCode plugin?
There was a problem hiding this comment.
not exactly, in VSCode code lenses are placed in any file that are in tests directory. I think it is not quite good, because if you open any file in tests dir and type in 'TEST' then code lenses for running utbot tests will appear, that's why I added an extra condition
There was a problem hiding this comment.
Not lenses but gutter to run a test.
alexey-utkin
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #394
To prevent run icons from showing in non-utbot-tests, add a condition to show them only in tests dir and in files which names contain word
test.