Skip to content

Fix recursive BUILD_DIR in test makefile #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix recursive BUILD_DIR in test makefile #410

merged 1 commit into from
Aug 30, 2022

Conversation

ladisgin
Copy link
Member

No description provided.

@ladisgin ladisgin linked an issue Aug 29, 2022 that may be closed by this pull request
Generated makefile has recursive dependency [BUG] #409
Closed
@ladisgin ladisgin marked this pull request as ready for review August 29, 2022 09:03
@ladisgin ladisgin requested review from S1eGa and Lana243 August 29, 2022 09:05
Lana243
Lana243 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@Lana243 Lana243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getRelativePath need be fixed. Please, open new issue for this.
Otherwise, LGTM

@ladisgin
Copy link
Member Author

Function getRelativePath need be fixed. Please, open new issue for this.

open issue #417

@ladisgin ladisgin merged commit 9216114 into main Aug 30, 2022
@ladisgin ladisgin deleted the ladisgin/fix_recursive_variable_in_makefile branch August 30, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S1eGa S1eGa S1eGa approved these changes

@Lana243 Lana243 Lana243 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated makefile has recursive dependency [BUG]
3 participants
@ladisgin @S1eGa @Lana243