Change representation of char* from string to array #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichunya
changed the title
sava-cska
requested changes
Nov 13, 2022
| @@ -254,12 +262,12 @@ namespace { | |||
| std::vector<TestCasePredicate>( | |||
| { [&predicate](const tests::Tests::MethodTestCase &testCase) { | |||
| // empty string | |||
| return testCase.paramValues[0].view->getEntryValue(nullptr).length() == 2 && | |||
| return testCase.paramValues[0].view->getEntryValue(nullptr).substr(2,2) == "\\0" && | |||
| predicate(testCase); | ||
| }, | ||
| [&predicate](const tests::Tests::MethodTestCase &testCase) { | ||
| // non-empty string | ||
| return testCase.paramValues[0].view->getEntryValue(nullptr).length() > 2 && | ||
| return testCase.paramValues[0].view->getEntryValue(nullptr).substr(2,2) != "\\0" && |
sava-cska
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Incorrect check post condition of char* ([BUG] #463) from string to array