Adding support for multiple variables of the same type to a plugin for vscode #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nypiaka
force-pushed
the
fix_issue_423
branch
from
fe50b39 to
d4ca616
Compare
Nypiaka
force-pushed
the
fix_issue_423
branch
5 times, most recently
from
b86581a to
cf080b8
Compare
ladisgin
reviewed
Mar 7, 2023
| @@ -133,6 +134,149 @@ namespace { | |||
| "buggy_function2"); | |||
| } | |||
|
|
|||
| static bool comparator(const std::string firstVar, const std::string secondVar, bool mustEqual, bool isInt){ | |||
ladisgin
requested changes
Mar 15, 2023
| return std::stoi(first.view->getEntryValue(nullptr)) == std::stoi(second.view->getEntryValue(nullptr)); | ||
| } | ||
|
|
||
| void checkDifferentVariablesTrue_C(BaseTestGen &testGen){ |
There was a problem hiding this comment.
unnecessary extract to function
| checkDifferentVariables_C(testGen, true); | ||
| } | ||
|
|
||
| void checkDifferentVariablesFalse_C(BaseTestGen &testGen){ |
There was a problem hiding this comment.
unnecessary extract to function
ladisgin
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.