fix: updaterunner item already added (#565)

pdeschain · pdeschain · commit 39b9055cedd0 · 2022-03-17T13:52:01.000-04:00
* Added guarding in update runner

* swapped for a slightly more performant check
diff --git a/Assets/BossRoom/Scripts/Shared/Infrastructure/UpdateRunner.cs b/Assets/BossRoom/Scripts/Shared/Infrastructure/UpdateRunner.cs
@@ -54,8 +54,10 @@ public void Subscribe(Action<float> onUpdate, float period)
             {
                 m_PendingHandlers.Enqueue(() =>
                 {
-                    m_Subscribers.Add(onUpdate);
-                    m_SubscriberData.Add(onUpdate, new SubscriberData(){Period = period, PeriodCurrent = 0});
+                    if (m_Subscribers.Add(onUpdate))
+                    {
+                        m_SubscriberData.Add(onUpdate, new SubscriberData() {Period = period, PeriodCurrent = 0});
+                    }
                 });
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,10 @@ public void Subscribe(Action<float> onUpdate, float period)`
`54`	`54`	`{`
`55`	`55`	`m_PendingHandlers.Enqueue(() =>`
`56`	`56`	`{`
`57`		`- m_Subscribers.Add(onUpdate);`
`58`		`- m_SubscriberData.Add(onUpdate, new SubscriberData(){Period = period, PeriodCurrent = 0});`
	`57`	`+ if (m_Subscribers.Add(onUpdate))`
	`58`	`+ {`
	`59`	`+ m_SubscriberData.Add(onUpdate, new SubscriberData() {Period = period, PeriodCurrent = 0});`
	`60`	`+ }`
`59`	`61`	`});`
`60`	`62`	`}`
`61`	`63`	`}`