fix: removing redundant lobby refresh and unsubscribing from lobby queries (#699)

fernando-cortez · web-flow · commit 3dba7e3f921b · 2022-08-01T11:44:08.000-04:00
diff --git a/Assets/Scripts/Gameplay/UI/Lobby/LobbyJoiningUI.cs b/Assets/Scripts/Gameplay/UI/Lobby/LobbyJoiningUI.cs
@@ -141,7 +141,6 @@ public void Show()
             m_CanvasGroup.alpha = 1f;
             m_CanvasGroup.blocksRaycasts = true;
             m_JoinCodeField.text = "";
-            OnRefresh();
             m_UpdateRunner.Subscribe(PeriodicRefresh, 10f);
         }
 
diff --git a/Assets/Scripts/Gameplay/UI/Lobby/LobbyUIMediator.cs b/Assets/Scripts/Gameplay/UI/Lobby/LobbyUIMediator.cs
@@ -220,6 +220,8 @@ public void Hide()
         {
             m_CanvasGroup.alpha = 0f;
             m_CanvasGroup.blocksRaycasts = false;
+            m_LobbyCreationUI.Hide();
+            m_LobbyJoiningUI.Hide();
         }
 
         public void ToggleJoinLobbyUI()

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,6 @@ public void Show()`
`141`	`141`	`m_CanvasGroup.alpha = 1f;`
`142`	`142`	`m_CanvasGroup.blocksRaycasts = true;`
`143`	`143`	`m_JoinCodeField.text = "";`
`144`		`- OnRefresh();`
`145`	`144`	`m_UpdateRunner.Subscribe(PeriodicRefresh, 10f);`
`146`	`145`	`}`
`147`	`146`
Original file line number	Diff line number	Diff line change
`@@ -220,6 +220,8 @@ public void Hide()`
`220`	`220`	`{`
`221`	`221`	`m_CanvasGroup.alpha = 0f;`
`222`	`222`	`m_CanvasGroup.blocksRaycasts = false;`
	`223`	`+ m_LobbyCreationUI.Hide();`
	`224`	`+ m_LobbyJoiningUI.Hide();`
`223`	`225`	`}`
`224`	`226`
`225`	`227`	`public void ToggleJoinLobbyUI()`