feat: better lobby exceptions handling (#568)

* Added switch-case to only show popups for Lobby exceptions pertinent to the users

Author: LPLafontaineB

Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs

@@ -49,25 +49,38 @@ void ServiceErrorHandler(UnityServiceErrorMessage error)
 
         void HandleLobbyError(UnityServiceErrorMessage error)
         {
-            var errorMessage = error.Message;
-            switch (((LobbyServiceException)error.OriginalException).Reason)
+            var exception = (LobbyServiceException) error.OriginalException;
+            if (exception != null)
             {
-                case LobbyExceptionReason.LobbyConflict:
+                switch (exception.Reason)
                 {
-                    errorMessage += "\nSee logs for possible causes and solution.";
-                    Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
-                        $"same machine. Please use command line arg '{ProfileManager.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
-                    break;
-                }
-                case LobbyExceptionReason.LobbyFull:
-                {
-                    PopupPanel.ShowPopupPanel("Failed to join lobby", "Lobby is full and can't accept more players");
-                    // Returning out of the function because we replace default popup panel with this.
-                    return;
+                    // If the error is one of the following, the player needs to know about it, so show in a popup message. Otherwise, the log in the console is sufficient.
+                    case LobbyExceptionReason.LobbyConflict:
+                        // LobbyConflict can have multiple causes. Let's add other solutions here if there's other situations that arise for this.
+                        Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
+                            $"same machine. Please use command line arg '{ProfileManager.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
+                        PopupPanel.ShowPopupPanel("Failed to join Lobby due to a conflict", "See logs for more details.");
+                        break;
+                    case LobbyExceptionReason.LobbyNotFound:
+                        PopupPanel.ShowPopupPanel("Lobby Not Found", "Requested lobby not found. See logs for details.");
+                        break;
+                    case LobbyExceptionReason.NoOpenLobbies:
+                        PopupPanel.ShowPopupPanel("Failed to join Lobby", "No accessible lobbies are currently available for quick-join.");
+                        break;
+                    case LobbyExceptionReason.LobbyFull:
+                        PopupPanel.ShowPopupPanel("Failed to join Lobby", "Lobby is full and can't accept more players.");
+                        break;
+                    case LobbyExceptionReason.Unauthorized:
+                        PopupPanel.ShowPopupPanel("Lobby error", "Unauthorized.");
+                        break;
+                    case LobbyExceptionReason.RequestTimeOut:
+                        PopupPanel.ShowPopupPanel("Lobby error", "Request timed out.");
+                        break;
+                    case LobbyExceptionReason.BadRequest:
+                        PopupPanel.ShowPopupPanel("Lobby error", "Received HTTP error 400 Bad Request from Lobby Service. Is the join code correctly formatted?");
+                        break;
                 }
             }
-
-            PopupPanel.ShowPopupPanel("Service error: " + error.Title, errorMessage);
         }
 
         void OnDestroy()

Assets/BossRoom/Scripts/Shared/Net/UnityServices/Lobbies/LobbyServiceFacade.cs

@@ -253,28 +253,7 @@ public void RemovePlayerFromLobbyAsync(string uasId, string lobbyId, Action onSu
         {
             if (m_LocalUser.IsHost)
             {
-                RetrieveLobbyAsync(lobbyId, OnRetrieveSuccess, onFailure);
-
-
-                void OnRetrieveSuccess(Lobby lobby)
-                {
-                    bool playerFound = false;
-                    foreach (var player in lobby.Players)
-                    {
-                        if (player.Id == uasId)
-                        {
-                            m_LobbyApiInterface.LeaveLobbyAsync(uasId, lobbyId, onSuccess, onFailure);
-                            playerFound = true;
-                            break;
-                        }
-                    }
-
-                    if (!playerFound)
-                    {
-                        Debug.Log($"Player {uasId} has already left the lobby.");
-                    }
-                }
-
+                m_LobbyApiInterface.LeaveLobbyAsync(uasId, lobbyId, onSuccess, onFailure);
             }
             else
             {