feat: client network transform move to samples [MTT-3406] (#629)

Author: SamuelBellomo

Assets/BossRoom/Scripts/Shared/Infrastructure/PubSub/MessageChannelDIExtensions.cs

@@ -1,3 +1,5 @@
+using System;
+
 namespace Unity.Multiplayer.Samples.BossRoom.Shared.Infrastructure
 {
     public static class MessageChannelDIExtensions
@@ -6,7 +8,7 @@ public static void BindMessageChannelInstance<TMessage>(this DIScope scope)
         {
             scope.BindInstanceAsSingle<MessageChannel<TMessage>, IPublisher<TMessage>, ISubscriber<TMessage>, IMessageChannel<TMessage>>(new MessageChannel<TMessage>());
         }
-        public static void BindNetworkedMessageChannelInstance<TMessage>(this DIScope scope) where TMessage : unmanaged
+        public static void BindNetworkedMessageChannelInstance<TMessage>(this DIScope scope) where TMessage : unmanaged, IComparable, IConvertible, IComparable<TMessage>, IEquatable<TMessage>
         {
             scope.BindInstanceAsSingle<NetworkedMessageChannel<TMessage>, IPublisher<TMessage>, ISubscriber<TMessage>, IMessageChannel<TMessage>>(new NetworkedMessageChannel<TMessage>());
         }

Assets/BossRoom/Scripts/Shared/Infrastructure/PubSub/NetworkedMessageChannel.cs

@@ -12,7 +12,7 @@ namespace Unity.Multiplayer.Samples.BossRoom.Shared.Infrastructure
     /// subscribing will be required each time a new session starts.
     /// </summary>
     /// <typeparam name="T"></typeparam>
-    public class NetworkedMessageChannel<T> : MessageChannel<T> where T : unmanaged
+    public class NetworkedMessageChannel<T> : MessageChannel<T> where T : unmanaged, IComparable, IConvertible, IComparable<T>, IEquatable<T>
     {
         string m_Name;
 

Assets/BossRoom/Scripts/Shared/NetworkNameState.cs

@@ -1,3 +1,4 @@
+using System;
 using Unity.Collections;
 using Unity.Netcode;
 using UnityEngine;
@@ -18,7 +19,7 @@ public class NetworkNameState : NetworkBehaviour
     /// </summary>
     public struct FixedPlayerName : INetworkSerializable
     {
-        private FixedString32Bytes m_Name;
+        ForceNetworkSerializeByMemcpy<FixedString32Bytes> m_Name; // using ForceNetworkSerializeByMemcpy to force compatibility between FixedString and NetworkSerializable
         public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReaderWriter
         {
             serializer.SerializeValue(ref m_Name);

Packages/com.unity.multiplayer.samples.coop/Utilities/Net/ClientAuthority.meta

@@ -0,0 +1,48 @@
+using Unity.Netcode.Components;
+using Unity.Netcode;
+using UnityEngine;
+
+namespace Unity.Multiplayer.Samples.Utilities.ClientAuthority
+{
+    // TODO inherit from `NetworkBehaviour` instead of `NetworkTransform` to cut direct relationship between two
+    // TODO change to owner netvar instead of RPC based
+    /// <summary>
+    /// Used for syncing a transform with client side changes. This includes host. Pure server as owner isn't supported by this. Please use NetworkTransform
+    /// for transforms that'll always be owned by the server.
+    /// </summary>
+    [DisallowMultipleComponent]
+    public class ClientNetworkTransform : NetworkTransform
+    {
+        /// <summary>
+        /// Used to determine who can write to this transform. Owner client only.
+        /// Changing this value alone will not allow you to create a NetworkTransform which can be written to by clients.
+        /// We're using RPCs to send updated values from client to server. Netcode doesn't support client side network variable writing.
+        /// This imposes state to the server. This is putting trust on your clients. Make sure no security-sensitive features use this transform.
+        /// </summary>
+        // This is public to make sure that users don't depend on this IsClient && IsOwner check in their code. If this logic changes in the future, we can make it invisible here
+
+        public override void OnNetworkSpawn()
+        {
+            base.OnNetworkSpawn();
+            CanCommitToTransform = IsOwner;
+        }
+
+        protected override void Update()
+        {
+            CanCommitToTransform = IsOwner;
+            base.Update();
+            if (NetworkManager.Singleton != null && (NetworkManager.Singleton.IsConnectedClient || NetworkManager.Singleton.IsListening))
+            {
+                if (CanCommitToTransform)
+                {
+                    TryCommitTransformToServer(transform, NetworkManager.LocalTime.Time);
+                }
+            }
+        }
+
+        protected override bool OnIsServerAuthoritatitive()
+        {
+            return false;
+        }
+    }
+}

Packages/com.unity.multiplayer.samples.coop/Utilities/Net/ClientAuthority/ClientNetworkTransform.cs

@@ -0,0 +1,17 @@
+{
+    "name": "Unity.Multiplayer.Samples.Utilities.ClientAuthority",
+    "rootNamespace": "",
+    "references": [
+        "Unity.Netcode.Components",
+        "Unity.Netcode.Runtime"
+    ],
+    "includePlatforms": [],
+    "excludePlatforms": [],
+    "allowUnsafeCode": false,
+    "overrideReferences": false,
+    "precompiledReferences": [],
+    "autoReferenced": true,
+    "defineConstraints": [],
+    "versionDefines": [],
+    "noEngineReferences": false
+}

Packages/com.unity.multiplayer.samples.coop/Utilities/Net/ClientAuthority/ClientNetworkTransform.cs.meta

@@ -1,14 +1,14 @@
 {
   "name": "com.unity.multiplayer.samples.coop",
-  "displayName": "Boss Room",
-  "version": "1.1.0-pre",
+  "displayName": "Multiplayer Samples Utilities",
+  "version": "1.2.0-pre",
   "type": "template",
   "host": "hub",
   "unity": "2020.3",
-  "description": "Boss Room is a small scale cooperative game sample project built on top of the new Unity Networking Core library, designed to help you explore the concepts and patterns behind a multiplayer game flow. \n\nBoss Room features character abilities, casting animations to hide latency, replicated objects, RPCs, and integration with a relay service.",
+  "description": "Utilities package built on top of Netcode for GameObjects, providing useful scripts and tools.",
   "dependencies": {
     "com.unity.learn.iet-framework": "1.2.1",
-    "com.unity.netcode.gameobjects": "1.0.0-pre.7",
+    "com.unity.netcode.gameobjects": "1.0.0-pre.8",
     "com.unity.services.authentication": "1.0.0-pre.4",
     "com.unity.services.lobby": "1.0.0-pre.6",
     "com.unity.services.relay": "1.0.1-pre.5"

Packages/com.unity.multiplayer.samples.coop/Utilities/Net/ClientAuthority/com.unity.multiplayer.samples.utilities.clientauthority.asmdef

@@ -121,7 +121,7 @@
       "source": "embedded",
       "dependencies": {
         "com.unity.learn.iet-framework": "1.2.1",
-        "com.unity.netcode.gameobjects": "1.0.0-pre.7",
+        "com.unity.netcode.gameobjects": "1.0.0-pre.8",
         "com.unity.services.authentication": "1.0.0-pre.4",
         "com.unity.services.lobby": "1.0.0-pre.6",
         "com.unity.services.relay": "1.0.1-pre.5"