feat: display popup when failing to connect to full lobby (#525) (#566)

(cherry picked from commit 18566e3)

Author: LukeStampfli

Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs

@@ -29,14 +29,7 @@ void ServiceErrorHandler(UnityServiceErrorMessage error)
             {
                 case UnityServiceErrorMessage.Service.Lobby:
                 {
-                    if ((error.OriginalException is LobbyServiceException {Reason: LobbyExceptionReason.LobbyConflict}))
-                    {
-                        // LobbyConflict can have multiple causes. Let's add other solutions here if there's other situations that arise for this.
-                        errorMessage += "\nSee logs for possible causes and solution.";
-                        Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
-                                $"same machine. Please use command line arg '{ProfileManager.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
-                    }
-                    PopupPanel.ShowPopupPanel("Service error", errorMessage);
+                    HandleLobbyError(error);
                     break;
                 }
                 case UnityServiceErrorMessage.Service.Authentication:
@@ -48,12 +41,35 @@ void ServiceErrorHandler(UnityServiceErrorMessage error)
                 }
                 default:
                 {
-            		PopupPanel.ShowPopupPanel("Service error: "+error.Title, errorMessage);
+                    PopupPanel.ShowPopupPanel("Service error: " + error.Title, errorMessage);
                     break;
                 }
             }
         }
 
+        void HandleLobbyError(UnityServiceErrorMessage error)
+        {
+            var errorMessage = error.Message;
+            switch (((LobbyServiceException)error.OriginalException).Reason)
+            {
+                case LobbyExceptionReason.LobbyConflict:
+                {
+                    errorMessage += "\nSee logs for possible causes and solution.";
+                    Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
+                        $"same machine. Please use command line arg '{ProfileManager.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
+                    break;
+                }
+                case LobbyExceptionReason.LobbyFull:
+                {
+                    PopupPanel.ShowPopupPanel("Failed to join lobby", "Lobby is full and can't accept more players");
+                    // Returning out of the function because we replace default popup panel with this.
+                    return;
+                }
+            }
+
+            PopupPanel.ShowPopupPanel("Service error: " + error.Title, errorMessage);
+        }
+
         void OnDestroy()
         {
             m_Subscriptions.Dispose();