feat: loading screen #427
Merged
feat: loading screen #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fernando Cortez <[email protected]>
* Renamed class and file to reflect naming conventions * Added namespace * Replaced magic string and const with serialized fields
This validation doesn't make sense anymore since in-scene imps are now in a different scene than the NavigationSystem
Replaced cooldown coroutine with one that unloads the scene after a delay. The coroutine is stopped in OnTriggerEnter, and before starting a new one if it wasn't stopped before.
…loading Reverted to polling to decide when to load/unload scenes instead of doing it in events to handle those intermediary states better
* Added support for non-networked game and for before the client connects
Packages/com.unity.multiplayer.samples.coop/Utilities/SceneManagement/SceneLoaderWrapper.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
previously approved these changes
Apr 6, 2022
…nt finishes sync before stopping loading screen Co-authored-by: Sam Bellomo <[email protected]>
fernando-cortez
previously approved these changes
Apr 6, 2022
fernando-cortez
added
2-One More Review
SamuelBellomo
previously approved these changes
Apr 6, 2022
LPLafontaineB
added
DO NOT MERGE
|
Adding DoNotMerge label until BossRoom is updated to NGO pre.7 |
LPLafontaineB
dismissed stale reviews from SamuelBellomo and fernando-cortez
via
28b37cc
LPLafontaineB
added
1-Needs Review
SamuelBellomo
approved these changes
Apr 8, 2022
LPLafontaineB
added
2-One More Review
fernando-cortez
approved these changes
Apr 12, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR adds a loading screen that appears when changing scenes.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-1960 MTT-1746
Manual testing scenarios
The host and the client should see the loading screen when starting the game, then when changing scenes to the CharSelect scene and the BossRoom scene. Those loading screens should hide the slight delay before player characters are spawned, during which the additive scene is not loaded in the BossRoom scene, the camera is at its default position, and the UI is at its default state. This should be more evident during step 5, which should hide the camera movement described in MTT-1746
Questions or comments
Contribution checklist