Skip to content

feat: kill enemies cheat #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 4, 2022
Merged

feat: kill enemies cheat #447

merged 19 commits into from
Mar 4, 2022

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Jan 19, 2022 •
edited
Loading

Description (*)

This PR adds two cheats. One kills the player's target (or destroy it if it is a breakable object. The second kills all enemies (all ServerCharacters with the IsNpc property). The first cheat can also be used to kill any player characters, including the player's own character.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2205 & MTT-2208

Manual testing scenarios

  1. Start a game and progress to BossRoomScene
  2. Open the cheat window
  3. Use the "Kill All Enemies" button or the "Kill Random Enemy" button

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Jan 21, 2022
@LPLafontaineB LPLafontaineB marked this pull request as ready for review January 21, 2022 16:28
@fernando-cortez fernando-cortez mentioned this pull request Jan 26, 2022
Merged
4 tasks
fernando-cortez
fernando-cortez previously approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Health wasn't clamped on successive cheat kills so that's been fixed over here, but this is good to go.

@LPLafontaineB
Copy link
Contributor Author

Health wasn't clamped on successive cheat kills so that's been fixed over here, but this is good to go.

Oh, nice catch! I feared using int.MinValue would lead to overflow, should have tested it on a player as well

@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Jan 27, 2022
@LPLafontaineB LPLafontaineB added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Feb 23, 2022
@LPLafontaineB
Copy link
Contributor Author

Put on hold until the GDC branch is ready

@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Feb 24, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Feb 24, 2022
View reviewed changes
@SamuelBellomo SamuelBellomo added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Feb 24, 2022
Base automatically changed from feature/Add-buttons-to-cheat-window to develop February 28, 2022 19:29
@LPLafontaineB LPLafontaineB requested review from SamuelBellomo and fernando-cortez and removed request for VALERE91Unity February 28, 2022 20:20
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 3-Good to Merge labels Mar 3, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 4, 2022
@LPLafontaineB LPLafontaineB merged commit 8f08a7c into develop Mar 4, 2022
@LPLafontaineB LPLafontaineB deleted the feature/kill-enemies-cheat branch March 4, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Assignees

@SamuelBellomo SamuelBellomo

@fernando-cortez fernando-cortez

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LPLafontaineB @SamuelBellomo @fernando-cortez