Skip to content

fix: connecting while starting game #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Mar 29, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR makes it so the closing of character selection and starting of a new game is cancelled when a new player joins or when a player quits. Players now have to re-confirm their choice when it happens so as to be properly informed of it.
This PR also cleans up ServerCharSelectState to align with our coding standards.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2358

Manual testing scenarios

  1. Start a game and go to character selection with one or more instances of the game
  2. On a second instance, join the game just after the last player hit ready
  3. See that the closing of character selection is properly cancelled and every player has to confirm their character again
  4. Confirm on all of them
  5. Just after the last player confirms, quit the session with one of the clients
  6. See that the closing of character selection is properly cancelled again

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB added the 1-Needs Review PR needs attention from the assignee and reviewers label Feb 14, 2022
@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 15, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 2-Reviewed with Comments PR requires owner's attention labels Feb 16, 2022
@LPLafontaineB LPLafontaineB changed the base branch from develop to release/GDC2022 March 2, 2022 16:41
@LPLafontaineB LPLafontaineB dismissed fernando-cortez’s stale review March 2, 2022 16:41

The base branch was changed.

@LPLafontaineB LPLafontaineB changed the base branch from release/GDC2022 to develop March 2, 2022 16:48
@LPLafontaineB LPLafontaineB marked this pull request as draft March 2, 2022 16:51
@LPLafontaineB LPLafontaineB force-pushed the fix/connecting-while-starting-game branch from 7f68a9c to d715946 Compare March 2, 2022 16:58
@LPLafontaineB LPLafontaineB marked this pull request as ready for review March 2, 2022 16:59
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers and removed 2-One More Review One review in, one to go labels Mar 7, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 21, 2022
@LPLafontaineB LPLafontaineB requested a review from pdeschain March 21, 2022 18:42
@LPLafontaineB LPLafontaineB merged commit 294d3fb into develop Mar 29, 2022
@LPLafontaineB LPLafontaineB deleted the fix/connecting-while-starting-game branch March 29, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-One More Review One review in, one to go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants