-
Notifications
You must be signed in to change notification settings - Fork 560
fix: connecting while starting game #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
previously approved these changes
Feb 16, 2022
The base branch was changed.
7f68a9c
to
d715946
Compare
fernando-cortez
approved these changes
Mar 21, 2022
SamuelBellomo
approved these changes
Mar 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR makes it so the closing of character selection and starting of a new game is cancelled when a new player joins or when a player quits. Players now have to re-confirm their choice when it happens so as to be properly informed of it.
This PR also cleans up ServerCharSelectState to align with our coding standards.
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): MTT-2358
Manual testing scenarios
Questions or comments
Contribution checklist