Skip to content

hack: hard code relay region #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

hack: hard code relay region #504

merged 1 commit into from
Mar 4, 2022

Conversation

SamuelBellomo
Copy link
Contributor

Description (*)

Should be handed by QoS in develop. Didn't want to add new feature in a stabilization branch, adding hardcoded region instead.

Issue Number(s) (*)

MTT-2690

Manual testing scenarios

  1. tested with us-east region, noticed lower RTT than central.
  2. tested with us-west region, noticed higher RTT than central.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@SamuelBellomo SamuelBellomo added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers 0-workaround labels Mar 3, 2022
@SamuelBellomo
Copy link
Contributor Author

waiting for test results from Matt and Ashwini, we saw some >200ms RTTs testing with Ashwini today. more investigation pending

@SamuelBellomo SamuelBellomo added 3-Good to Merge 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 3, 2022
@SamuelBellomo SamuelBellomo merged commit 87eaaa2 into release/GDC2022 Mar 4, 2022
@SamuelBellomo SamuelBellomo deleted the sam/feature/hard-code-relay-region branch March 4, 2022 01:57
@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagownt thiagownt thiagownt approved these changes

@ashwinimurt ashwinimurt ashwinimurt approved these changes

@mattwalsh-unity mattwalsh-unity mattwalsh-unity approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@ralahhaddadunity ralahhaddadunity ralahhaddadunity approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees
No one assigned
Labels
0-workaround 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamuelBellomo @thiagownt @ashwinimurt @mattwalsh-unity @LPLafontaineB @ralahhaddadunity