Skip to content

Simplified Floor Tiles #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Mar 4, 2022

Description (*)

This PR is part of the art improvements for GDC epic. The ~750 tiny floor tiles have been replaced with a mix of ~150 larger and small floor tiles. Replacing the hundreds of small tiles with larger tiles reduces scene complexity (making it easier to manage and modify the level), reduces vert/tri count (aiding performance), and makes lighting bakes cleaner/faster (by reducing the amount of objects that need to bake, and reducing the amount of places there can be seams).

Prefabs for the new pieces have been created

Prefabs for Entrance, Transition Area, and Boss Room have been changed to use these new tiles

Lighting has been rebaked

Issue Number(s) (*)

Jira ticket here

@jilfranco-unity jilfranco-unity added 1-Needs Review PR needs attention from the assignee and reviewers type:feature New feature, request or improvement labels Mar 4, 2022
@SamuelBellomo
Copy link
Contributor

@jilfranco-unity
Is this just for GDC or both GDC and develop?
Also watch out, this points to develop at the moment.

@jilfranco-unity
Copy link
Contributor Author

This would be for both! I think it's good to have this change overall. At which branch should it point if I want the change for both?

@SamuelBellomo
Copy link
Contributor

This would be for both! I think it's good to have this change overall. At which branch should it point if I want the change for both?

@jilfranco-unity this is fine, but we'll need to cherrypick your squashed commit once its merged to develop. Hopefully that's something you can do (in case there are conflicts). We can do it together if you need help.

@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 7, 2022
@jilfranco-unity jilfranco-unity added the WIP Work In Progress label Mar 8, 2022
… down to ~60 pieces. Edited the UVs of the bigger floor tiles to break up repeating texture with the texture that was on floor 2
@jilfranco-unity jilfranco-unity added 1-Needs Review PR needs attention from the assignee and reviewers and removed WIP Work In Progress 2-Reviewed with Comments PR requires owner's attention labels Mar 8, 2022
@jilfranco-unity
Copy link
Contributor Author

Removed accent floor 2 & floor 3 pieces to further simplify the floor down to ~60 pieces. Edited the UVs of the bigger floor tiles to break up repeating texture with the texture that was on floor 2

SamuelBellomo
SamuelBellomo previously approved these changes Mar 8, 2022
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you push the changes to the floor Colliders to the prefabs themselves as well?

SamuelBellomo
SamuelBellomo previously approved these changes Mar 8, 2022
@jilfranco-unity jilfranco-unity merged commit b83d7b4 into develop Mar 8, 2022
@jilfranco-unity jilfranco-unity deleted the feat/jil/bigger-floor-pieces branch March 8, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick priority:high priority:highest type:feature New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants