Skip to content

fix: NetworkAnimator being called on clients #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,22 @@ public class ServerAnimationHandler : NetworkBehaviour
NetworkAnimator m_NetworkAnimator;

[SerializeField]
private VisualizationConfiguration m_VisualizationConfiguration;
VisualizationConfiguration m_VisualizationConfiguration;

[SerializeField]
NetworkLifeState m_NetworkLifeState;

public NetworkAnimator NetworkAnimator
{
get => m_NetworkAnimator;
set => m_NetworkAnimator = value;
}
public NetworkAnimator NetworkAnimator => m_NetworkAnimator;

public override void OnNetworkSpawn()
{
m_NetworkLifeState.LifeState.OnValueChanged += OnLifeStateChanged;
if (IsServer)
{
m_NetworkLifeState.LifeState.OnValueChanged += OnLifeStateChanged;
}
}

private void OnLifeStateChanged(LifeState previousValue, LifeState newValue)
void OnLifeStateChanged(LifeState previousValue, LifeState newValue)
{
switch (newValue)
{
Expand All @@ -47,7 +46,10 @@ private void OnLifeStateChanged(LifeState previousValue, LifeState newValue)

public override void OnNetworkDespawn()
{
m_NetworkLifeState.LifeState.OnValueChanged -= OnLifeStateChanged;
if (IsServer)
{
m_NetworkLifeState.LifeState.OnValueChanged -= OnLifeStateChanged;
}
}
}
}