Skip to content

Lobby UI Visual Rework #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Conversation

jilfranco-unity
Copy link
Contributor

Description (*)

A bit of a facelift for the lobby UI--mainly moving things around, adding color to the scroll bar, adding some graphics, and adding borders to the tabs to make them more like radio buttons

New Look:
image
image
image
image
image

Old Look:
image
image
image
image
image

Issue Number(s) (*)

Jira ticket here

…ng some graphics, changing scroll bar color and scroll settings, and adding border visuals to the tabs to make it more obvious which tab you have selected
@jilfranco-unity jilfranco-unity added 1-Needs Review PR needs attention from the assignee and reviewers priority:high GDC-cherrypick labels Mar 8, 2022
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Mar 8, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Mar 8, 2022
LPLafontaineB
LPLafontaineB previously approved these changes Mar 8, 2022
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve once merge conflict is addressed. Looks much better👍

@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 8, 2022
# Conflicts resolved with unity merge tool
#	Assets/BossRoom/Scenes/MainMenu.unity
@jilfranco-unity jilfranco-unity added 2-One More Review One review in, one to go and removed 2-Reviewed with Comments PR requires owner's attention labels Mar 8, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Mar 8, 2022
@jilfranco-unity jilfranco-unity merged commit be3c9c6 into develop Mar 8, 2022
@jilfranco-unity jilfranco-unity deleted the fix/lobby-tab-visual-rework branch March 8, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-URGENT Blocker for a release and needs to be merged ASAP 3-Good to Merge GDC-cherrypick priority:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants