Skip to content

fix: adjusted layer collision matrix #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

fix: adjusted layer collision matrix #541

merged 1 commit into from
Mar 11, 2022

Conversation

pdeschain
Copy link
Contributor

Description (*)

PCs and NPCs were capable of colliding with column pieces (the Debris layer). I've adjusted the collision matrix to prevent this.

Related Pull Requests

Issue Number(s) (*)

MTT-2469 - https://jira.unity3d.com/browse/MTT-2469

Fixes issue(s):

Manual testing scenarios

  1. Start the game and go to the Boss's room
  2. Make the Boss run into some columns - observe that the columns break, but the pieces just fall to the ground and afterwards are not interactable with the PCs and NPCs

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@pdeschain
Adjusted layer collision matrix
d9dec1d 
debris no longer collides with NPCs and PCs
@pdeschain pdeschain added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 11, 2022
@pdeschain pdeschain marked this pull request as ready for review March 11, 2022 14:14
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 11, 2022
@fernando-cortez fernando-cortez merged commit 966b120 into develop Mar 11, 2022
@fernando-cortez fernando-cortez deleted the pdeschain/column-pieces-no-physics branch March 11, 2022 20:10
pdeschain added a commit that referenced this pull request Mar 11, 2022
@pdeschain
Adjusted layer collision matrix (#541)
fc1ed64 
debris no longer collides with NPCs and PCs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees
No one assigned
Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdeschain @SamuelBellomo @fernando-cortez @LPLafontaineB