fix: nav mesh floating patches removed #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
4 tasks
LPLafontaineB
previously approved these changes
Mar 11, 2022
SamuelBellomo
previously approved these changes
Mar 11, 2022
SamuelBellomo
added
3-Good to Merge
and removed
1-Needs Review
fernando-cortez
dismissed stale reviews from SamuelBellomo and LPLafontaineB
via
56df969
fernando-cortez
force-pushed
the
fix/nav-mesh-floaters-removed
branch
from
24c0500 to
56df969
Compare
|
Prefabs were reverted, as they'll be properly modified with new layers in the fix PR for the rogue dash, since they're related. |
fernando-cortez
added
1-Needs Review
SamuelBellomo
approved these changes
Mar 11, 2022
LPLafontaineB
approved these changes
Mar 11, 2022
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
fernando-cortez
added a commit
that referenced
this pull request
Mar 11, 2022
4 tasks
SamuelBellomo
pushed a commit
that referenced
this pull request
Mar 11, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR brings a QoL fix for navigation. The nav mesh in the game scene had floaters due to some objects not being excluded outright from the bake, as seen below:
The new bake:
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s): This is a QoL PR which came about from working on MTT-2412.
This is a cherrypick-able fix that should be in develop as well.
A subsequent PR will actually address the issue of the Rogue being able to dash to tops of columns.
Edit: the prefabs that were modified here initially will instead be modified in the rogue dash fix PR.
Contribution checklist