Fix: More Lobby Visual Work #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts resolved with unity merge tool: # Assets/BossRoom/Scenes/MainMenu.unity # Assets/BossRoom/Scripts/Client/UI/IPUIMediator.cs
… as well as adjusting settings so that the UI looks a little better at other aspect ratios besides 16:9
jilfranco-unity
requested review from
pdeschain,
fernando-cortez and
LPLafontaineB
jilfranco-unity
added
1-Needs Review
SamuelBellomo
previously approved these changes
Mar 11, 2022
|
nice, really cool! |
|
Oh hey, I just realized that the tabs for the IP window say "Lobby List" and "Create Lobby"--I've changed them to "Join with IP" and "Host with IP" instead
Sorry for immediately dismissing your approval Sam :P |
SamuelBellomo
approved these changes
Mar 11, 2022
|
|
LPLafontaineB
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR includes further work on the Lobby UI, specifically the tabs. The goal of these changes is to make the UI more intuitive after receiving feedback during a playtest that the tabs still looked too much like buttons, rather than tabs
Some pictures! :)
Lobby list before:
Lobby list after:
Lobby creation before:
Lobby creation after:
IP join before:
IP join after:
IP host before:
IP host after:
Issue Number(s) (*)
Jira ticket here