Skip to content

fix: unready button not clickable on wide screens #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2022
Merged

fix: unready button not clickable on wide screens #552

merged 2 commits into from
Mar 15, 2022

Conversation

pdeschain
Copy link
Contributor

@pdeschain pdeschain commented Mar 15, 2022 •
edited
Loading

Description (*)

I've adjusted the UI in such a way that on wide screens (21:9 was my reference resolution) the Unready button is not as overlapped by character selection thingy. I've also made the clickable zone for the character selectors smaller. Character selection animation that slides the character image upward was also made less dramatic. Overall it's much easier to hit the unready button now.

Related Pull Requests

Issue Number(s) (*)

MTT-2470

Fixes issue(s):

Manual testing scenarios

  1. Start the game with two clients on a wide aspect ratio
  2. Select the right-most character in the character selection and hit ready.
  3. Observe that the unready button is much easier to get to now.

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@pdeschain pdeschain added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 15, 2022
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 15, 2022
@pdeschain pdeschain merged commit 968029c into develop Mar 15, 2022
@pdeschain pdeschain deleted the pdeschain/unready-not-clickable-on-wide-screens-fix branch March 15, 2022 17:26
pdeschain added a commit that referenced this pull request Mar 15, 2022
@pdeschain
fix: unready button not clickable on wide screens (#552)
f9abb3c 
* Adjusted animation and clickable zone on character selection button

* Made the top-right info display slightly more compact in char select scene
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees
No one assigned
Labels
2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdeschain @SamuelBellomo @LPLafontaineB