cherrypick fix: leaving lobby when connection denied (#551) #556
+47
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* client now leaves lobby if their connection gets denied * host now removes client from lobby when denying connection * Moved beginning of lobby tracking to after successful connection through ngo (cherry picked from commit 7ec53d1)
LPLafontaineB
added
1-Needs Review
SamuelBellomo
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
(cherry picked from commit 7ec53d1) (#551) Without the code relating to auto-reconnect
Related Pull Requests
Issue Number(s) (*)
Fixes issue(s):
Manual testing scenarios
Questions or comments
Contribution checklist