Skip to content

fix: mage FX graphics not offset #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix: mage FX graphics not offset #571

merged 1 commit into from
Mar 17, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description (*)

One of Mage's FX was offset at (0,0,50) on spawn. Resetting that offset removes the weird green FX teleportation bug.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-2842

Manual testing scenarios

  1. Do Mage Heal and rotate around & move.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 17, 2022
@fernando-cortez fernando-cortez merged commit 0d8d44a into release/GDC2022 Mar 17, 2022
@fernando-cortez fernando-cortez deleted the fix/mage-particle-fx-offsetting branch March 17, 2022 20:02
fernando-cortez added a commit that referenced this pull request Mar 18, 2022
@fernando-cortez
mage FX graphics not offset (#571)
a260d54
@fernando-cortez fernando-cortez mentioned this pull request Mar 18, 2022
Merged
4 tasks
SamuelBellomo pushed a commit that referenced this pull request Mar 18, 2022
@fernando-cortez
mage FX graphics not offset (#571) (#575)
4813ced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@jilfranco-unity jilfranco-unity Awaiting requested review from jilfranco-unity

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @pdeschain @SamuelBellomo