Skip to content

feat: other players loading progress in loading screen [MTT-2239] #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
May 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
7180d08
Split dungeon prefab in multiple parts
LPLafontaineB Nov 26, 2021
ef66b05
Added additive scene loading for BossRoom scene
LPLafontaineB Nov 26, 2021
382a1a7
rebaked lighting and cleaned up prefabs
LPLafontaineB Nov 30, 2021
591f480
Merge branch 'develop' into feature/additive-scene-loading
LPLafontaineB Dec 1, 2021
f08b957
reorganised sub-scene prefabs and added description to class Additive…
LPLafontaineB Dec 1, 2021
e90212e
Added support for disconnecting players to AdditiveSceneLoader
LPLafontaineB Dec 1, 2021
1073d7c
Moving static network objects to their respective sub-scene
LPLafontaineB Dec 2, 2021
1083bc1
Made the collider trigger for loading the transition area bigger
LPLafontaineB Dec 3, 2021
54ca6c2
Apply suggestions from code review
LPLafontaineB Dec 7, 2021
6a95ea1
Improving AdditiveSceneLoader usability
LPLafontaineB Dec 7, 2021
a2dc555
Zeroed root GameObjects in prefabs and removed unused GameObjects in …
LPLafontaineB Dec 7, 2021
45c3e0c
Removed NavigationSystem validation from ServerCharacterMovement
LPLafontaineB Dec 8, 2021
c70eede
Adding clarifying comments and renaming tag field
LPLafontaineB Dec 9, 2021
e27e48e
Adding clarifying comments
LPLafontaineB Dec 10, 2021
348df86
moving the update() code to OnTriggerEnter and Exit
LPLafontaineB Dec 10, 2021
a1ae252
Created loading screen
LPLafontaineB Dec 10, 2021
c4a81da
Added SceneState enum to consider states where scene is loading or un…
LPLafontaineB Dec 10, 2021
a7bea97
Added handling of when SceneManager cannot start load/unload event
LPLafontaineB Dec 13, 2021
4ea5d1e
Merge branch 'feature/additive-scene-loading' into feature/loading-sc…
LPLafontaineB Dec 13, 2021
558bee8
fixed naming conventions errors
LPLafontaineB Dec 13, 2021
af3e97c
Merge branch 'feature/additive-scene-loading' into feature/loading-sc…
LPLafontaineB Dec 13, 2021
378e5b9
Added time stopping during loading screen
LPLafontaineB Dec 13, 2021
06906e0
Added verification that ServerAdditiveSceneLoader is spawned in OnTri…
LPLafontaineB Dec 13, 2021
2639279
Fixing typo and adding more comments
LPLafontaineB Dec 14, 2021
3be25a7
Merge branch 'feature/additive-scene-loading' into feature/loading-sc…
LPLafontaineB Dec 14, 2021
13924d2
Removed NetworkObject from LoadingScreen
LPLafontaineB Dec 14, 2021
587085e
Removed handling of server-side events
LPLafontaineB Dec 14, 2021
85c8ac0
Preventing LoadingScreen from blocking clicks on what is behind it
LPLafontaineB Dec 14, 2021
ea625ac
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Dec 14, 2021
9078db0
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Dec 15, 2021
6b797f8
Added SceneLoader script
LPLafontaineB Dec 16, 2021
c6423e6
Added slight delay before starting to fade out to allow multiple sequ…
LPLafontaineB Dec 16, 2021
6c30be5
Tweaking SceneEvents handling
LPLafontaineB Dec 16, 2021
c2a1434
Added client RPC to stop loading screen after SynchronizeComplete
LPLafontaineB Dec 17, 2021
760bd1c
Fixed GlobalObjectIdHash for SceneLoader
LPLafontaineB Dec 17, 2021
183957b
Cleaning up and adding comments
LPLafontaineB Dec 17, 2021
435b6d6
adding class descriptions and checks for if scene management is enabled
LPLafontaineB Jan 5, 2022
c01974b
Simplified SceneLoader
LPLafontaineB Jan 5, 2022
2665564
Cleaning up and adding comments
LPLafontaineB Jan 6, 2022
40f54ec
Modified class name
LPLafontaineB Jan 6, 2022
4dd40e4
Renamed SceneLoader to SceneLoaderWrapper and moved the loading of Ch…
LPLafontaineB Jan 6, 2022
320500b
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Jan 10, 2022
aeaa412
Added Single as default scene loading mode
LPLafontaineB Jan 11, 2022
167fb5f
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Jan 21, 2022
dbb8a21
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Feb 25, 2022
91d087d
fixed typo
LPLafontaineB Feb 25, 2022
abf4f3b
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Mar 18, 2022
1c78b15
Adding loading screen when leaving session
LPLafontaineB Mar 18, 2022
82b39f1
Reduced fadeout duration
LPLafontaineB Mar 22, 2022
15569b3
simplified conditions for loading offline vs online
LPLafontaineB Mar 22, 2022
849610f
moved loading first scene to OnServerStarted
LPLafontaineB Mar 22, 2022
28ab0d3
Adding way to track loading progress of other players
LPLafontaineB Mar 23, 2022
569dbe4
current loading progress is now updated by LoadingProgressManager
LPLafontaineB Mar 24, 2022
c998d94
Added other player names to loading screen
LPLafontaineB Mar 24, 2022
65df3e2
Added support for dynamically adding and removing other players' prog…
LPLafontaineB Mar 24, 2022
da4da74
resetting prefab to default values for player names
LPLafontaineB Mar 24, 2022
7daeab1
cleanup
LPLafontaineB Mar 24, 2022
5bb01a1
Adding comments
LPLafontaineB Mar 24, 2022
c1daf46
replaced IsClient checks with NetworkManager.IsClient
LPLafontaineB Mar 28, 2022
14239ea
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Apr 5, 2022
6ab9b89
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Apr 5, 2022
98742c6
simplified wait inside fadeoutcoroutine
LPLafontaineB Apr 6, 2022
59b7c65
Adding comment to give example of why we are waiting 1 rtt after clie…
LPLafontaineB Apr 6, 2022
2fff187
removed unused using directives
LPLafontaineB Apr 6, 2022
28b37cc
Merge branch 'develop' into feature/loading-screen
LPLafontaineB Apr 7, 2022
3cde27b
Merge branch 'feature/loading-screen' into feature/other-players-load…
LPLafontaineB Apr 7, 2022
1f61e59
Merge branch 'develop' into feature/other-players-loading-progress
LPLafontaineB Apr 12, 2022
7d58947
Merge branch 'develop' into feature/other-players-loading-progress
LPLafontaineB Apr 20, 2022
651139e
Merge branch 'develop' into feature/other-players-loading-progress
LPLafontaineB Apr 22, 2022
b8e0cb3
Removing NetworkBehaviour inheritance in ClientLoadingScreen
LPLafontaineB Apr 27, 2022
a428689
making LocalProgress get point to NetworkedVariable when available
LPLafontaineB Apr 27, 2022
0eba777
Making sure loading trackers are properly updated when a client disco…
LPLafontaineB Apr 27, 2022
19cdd8b
removed double ifs
LPLafontaineB May 3, 2022
d705c48
Adding comments
LPLafontaineB May 3, 2022
f7e6413
Merge branch 'develop' into feature/other-players-loading-progress
LPLafontaineB May 3, 2022
a3f7e2a
fixing conflict
LPLafontaineB May 3, 2022
480d44f
Adding IsSpawned check to remove WaitBeforeSendingRPC
LPLafontaineB May 3, 2022
4fd2fcf
removing NetworkObject from LoadinScreen prefab
LPLafontaineB May 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions Assets/BossRoom/Prefabs/LoadingProgressTracker.prefab
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
%YAML 1.1
%TAG !u! tag:unity3d.com,2011:
--- !u!1 &3106828016798330210
GameObject:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
serializedVersion: 6
m_Component:
- component: {fileID: 3106828016798330215}
- component: {fileID: 3106828016798330208}
- component: {fileID: 3106828016798330209}
m_Layer: 0
m_Name: LoadingProgressTracker
m_TagString: Untagged
m_Icon: {fileID: 0}
m_NavMeshLayer: 0
m_StaticEditorFlags: 0
m_IsActive: 1
--- !u!4 &3106828016798330215
Transform:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 3106828016798330210}
m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
m_LocalPosition: {x: 0, y: 0, z: 0}
m_LocalScale: {x: 1, y: 1, z: 1}
m_Children: []
m_Father: {fileID: 0}
m_RootOrder: 0
m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
--- !u!114 &3106828016798330208
MonoBehaviour:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 3106828016798330210}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 8e20ce98a70947b68f7982c1c417f88c, type: 3}
m_Name:
m_EditorClassIdentifier:
--- !u!114 &3106828016798330209
MonoBehaviour:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 3106828016798330210}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: d5a57f767e5e46a458fc5d3c628d0cbb, type: 3}
m_Name:
m_EditorClassIdentifier:
GlobalObjectIdHash: 951099334
AlwaysReplicateAsRoot: 0
DontDestroyWithOwner: 0
AutoObjectParentSync: 1
7 changes: 7 additions & 0 deletions Assets/BossRoom/Prefabs/LoadingProgressTracker.prefab.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 26 additions & 10 deletions Assets/BossRoom/Prefabs/NetworkingManager.prefab
Original file line number Diff line number Diff line change
Expand Up @@ -184,50 +184,66 @@ MonoBehaviour:
NetworkConfig:
ProtocolVersion: 0
NetworkTransport: {fileID: 5486862276979889515}
PlayerPrefab: {fileID: 4927145850774787080, guid: 1d3f5528d25661949890bcd7f47fe81a, type: 3}
PlayerPrefab: {fileID: 4927145850774787080, guid: 1d3f5528d25661949890bcd7f47fe81a,
type: 3}
NetworkPrefabs:
- Override: 0
Prefab: {fileID: 6009713983291384756, guid: 8237adf32a9b6de4892e6febe6b4bdef, type: 3}
Prefab: {fileID: 6009713983291384756, guid: 8237adf32a9b6de4892e6febe6b4bdef,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 3713729372785093424, guid: 6cdd52f1fa2ed34469a487ae6477eded, type: 3}
Prefab: {fileID: 3713729372785093424, guid: 6cdd52f1fa2ed34469a487ae6477eded,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 3688950541947916333, guid: 365e94337fd10fe4ebde1906df413ac7, type: 3}
Prefab: {fileID: 3688950541947916333, guid: 365e94337fd10fe4ebde1906df413ac7,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 2842198241268549130, guid: 30c420f004b8f6445ad2bdb2addb234a, type: 3}
Prefab: {fileID: 2842198241268549130, guid: 30c420f004b8f6445ad2bdb2addb234a,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 2842198241268549130, guid: 7e3b8103f5622f64fa677352730f295c, type: 3}
Prefab: {fileID: 2842198241268549130, guid: 7e3b8103f5622f64fa677352730f295c,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 2842198241268549130, guid: 411974b75a8b43d4e9b3c9069a5067fb, type: 3}
Prefab: {fileID: 2842198241268549130, guid: 411974b75a8b43d4e9b3c9069a5067fb,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 2842198241268549130, guid: 0251e08eeed89e844a8527b3a7874cc2, type: 3}
Prefab: {fileID: 2842198241268549130, guid: 0251e08eeed89e844a8527b3a7874cc2,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 576565557002701866, guid: 3af96a32a84bcf74d9538fa7af973c97, type: 3}
Prefab: {fileID: 576565557002701866, guid: 3af96a32a84bcf74d9538fa7af973c97,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 3597354879354517420, guid: c8513d3df780cb34a9576da3772d512b, type: 3}
Prefab: {fileID: 3597354879354517420, guid: c8513d3df780cb34a9576da3772d512b,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
- Override: 0
Prefab: {fileID: 3106828016798330210, guid: 5c107a985e30aa2469a62ecf015d43a8,
type: 3}
SourcePrefabToOverride: {fileID: 0}
SourceHashToOverride: 0
OverridingTargetPrefab: {fileID: 0}
Expand Down
27 changes: 15 additions & 12 deletions Assets/BossRoom/Prefabs/SceneLoader.prefab
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ GameObject:
- component: {fileID: 7533068275093218427}
- component: {fileID: 2071498811241465156}
- component: {fileID: 8734696198808489477}
- component: {fileID: 6240023712540756099}
m_Layer: 0
m_Name: SceneLoader
m_TagString: Untagged
Expand Down Expand Up @@ -44,19 +45,8 @@ MonoBehaviour:
m_Script: {fileID: 11500000, guid: d202c9ed4a2c4a6fa83f21f1c21394ea, type: 3}
m_Name:
m_EditorClassIdentifier:
m_ScenesTriggeringLoadingScreen:
- MainMenu
- CharSelect
- PostGame
- BossRoom
m_ScenesEndingLoadingScreen:
- MainMenu
- CharSelect
- PostGame
- DungeonEntrance
- DungeonTransition
- DungeonBossRoom
m_ClientLoadingScreen: {fileID: 0}
m_LoadingProgressManager: {fileID: 6240023712540756099}
--- !u!114 &8734696198808489477
MonoBehaviour:
m_ObjectHideFlags: 0
Expand All @@ -73,3 +63,16 @@ MonoBehaviour:
AlwaysReplicateAsRoot: 0
DontDestroyWithOwner: 0
AutoObjectParentSync: 1
--- !u!114 &6240023712540756099
MonoBehaviour:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 5970766024194302363}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 831202463f434661b4f61a409b08867f, type: 3}
m_Name:
m_EditorClassIdentifier:
m_ProgressTrackerPrefab: {fileID: 3106828016798330210, guid: 5c107a985e30aa2469a62ecf015d43a8, type: 3}
Loading