fix: decoupling SessionManager from NetworkManager [MTT-2603] #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed NetworkManager field * Removed callback registrations and replaced them with calls from GameNetPortal
…ing the rest on session end
…necting player's data
LPLafontaineB
added
the
1-Needs Review
LPLafontaineB
requested review from
pdeschain,
LukeStampfli and
fernando-cortez
fernando-cortez
previously approved these changes
Mar 29, 2022
fernando-cortez
added
2-One More Review
Merged
3 tasks
Packages/com.unity.multiplayer.samples.coop/Utilities/Net/SessionManager.cs
Show resolved
Hide resolved
LPLafontaineB
added
1-Needs Review
pdeschain
reviewed
Apr 5, 2022
Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ServerGameNetPortal.cs
Show resolved
Hide resolved
SamuelBellomo
approved these changes
Apr 5, 2022
LPLafontaineB
removed
the
1-Needs Review
4 tasks
pdeschain
approved these changes
Apr 6, 2022
LPLafontaineB
deleted the
fix/decoupling-session-manager-from-net-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes dependencies that SessionManager had on NetworkManager, by removing it as a field and replacing the callbacks it registered to with public methods called from GameNetPortal. This solves the issues of the SessionManager not handling the destruction of the NetworkManager and the creation of a new one. In such a case, the SessionManager would have no idea it happened and would not unregister its callbacks and register them again on the new NetworkManager instance.
This PR also simplifies the handling of clearing data from disconnected players and reinitializing the rest when dealing with successive game sessions. We now simply do it when a session ends. Furthermore, a new field tells the SessionManager if a session is currently started, so that when a client disconnects it can decide if it needs to keep their data or not.
Issue Number(s)
MTT-2603
Contribution checklist