VFX Optimization Pass #584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR for an optimization pass done on all of our VFX. This was prompted by seeing how complex our Boss effects were--I wanted to check in on the rest of our VFX to make sure they weren't overly complex. For the most part, we were in great shape! But there were some things I was able to simplify.
Things changed:
Most of these changes are meant to be invisible/have the effects look the same, but be less expensive, but here are some videos of things that have changed visually!
Imp bomb explosion before (most likely these materials got messed up in the port to URP when I re-hooked up all of our materials, but went unnoticed since we don't use this effect in game):
https://user-images.githubusercontent.com/89089503/160487206-17423439-dde0-4dc9-8b3f-ca53f430e996.mp4
Imp bomb explosion after:
https://user-images.githubusercontent.com/89089503/160487253-cddb3d51-3c79-4627-8d37-01b44942832e.mp4
Archer attacks before:
https://user-images.githubusercontent.com/89089503/160487721-654dfa38-9f52-4906-97c8-0828bec23c99.mp4
Archer attacks after (using what what already there, I mostly just modified colors, positions, and particle sizes to get the effects I wanted):
https://user-images.githubusercontent.com/89089503/160487740-c690c169-f21b-4993-8ce2-7e51af85ba44.mp4
Issue Number(s)
Jira ticket here