Skip to content

VFX Optimization Pass #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2022
Merged

VFX Optimization Pass #584

merged 3 commits into from
Mar 29, 2022

Conversation

jilfranco-unity
Copy link
Contributor

Description

This is a PR for an optimization pass done on all of our VFX. This was prompted by seeing how complex our Boss effects were--I wanted to check in on the rest of our VFX to make sure they weren't overly complex. For the most part, we were in great shape! But there were some things I was able to simplify.

Things changed:

  • Imp defeat from ~95 particles to ~35
  • Imp bomb throw explosion effect materials fixed and effect modified overall to look more convincing
  • Slash effects meshes for tank, imp, rogue vert counts reduced by about half
  • Archer arrow billboard mesh vert count reduced by 75%
  • Lots of trail effects vert counts reduced by about half
  • Archer charged arrow effects simplified and modified to make the difference between the 3 tiers more noticeable, charged shot arrow size increased to 1.5 across all 3 tiers to match with regular attack arrow size
  • Supporting material edits made as needed
  • Typo corrected in one of the mesh names
  • Run smoke max particle limit and lifetime reduced some more, as well as particle size reduced slightly from 3 to 2.5 'cause it looked too large imo

Most of these changes are meant to be invisible/have the effects look the same, but be less expensive, but here are some videos of things that have changed visually!

Imp bomb explosion before (most likely these materials got messed up in the port to URP when I re-hooked up all of our materials, but went unnoticed since we don't use this effect in game):
https://user-images.githubusercontent.com/89089503/160487206-17423439-dde0-4dc9-8b3f-ca53f430e996.mp4

Imp bomb explosion after:
https://user-images.githubusercontent.com/89089503/160487253-cddb3d51-3c79-4627-8d37-01b44942832e.mp4

Archer attacks before:
https://user-images.githubusercontent.com/89089503/160487721-654dfa38-9f52-4906-97c8-0828bec23c99.mp4

Archer attacks after (using what what already there, I mostly just modified colors, positions, and particle sizes to get the effects I wanted):
https://user-images.githubusercontent.com/89089503/160487740-c690c169-f21b-4993-8ce2-7e51af85ba44.mp4

Issue Number(s)

Jira ticket here

…eaks to make things more consistent / fix broken things
…as particle size reduced slightly from 3 to 2.5 'cause it looked too large imo
@jilfranco-unity jilfranco-unity added 1-Needs Review PR needs attention from the assignee and reviewers type:feature New feature, request or improvement labels Mar 28, 2022
@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 29, 2022
@jilfranco-unity jilfranco-unity merged commit 1a1b8cc into develop Mar 29, 2022
@jilfranco-unity jilfranco-unity deleted the fix/vfx-optimization-pass-1 branch March 29, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-Good to Merge type:feature New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants