Skip to content

fix: performance improvements (CPU-only) #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix: performance improvements (CPU-only) #590

merged 2 commits into from
Apr 5, 2022

Conversation

fernando-cortez
Copy link
Collaborator

Description

Performance QoL improvements (all CPU-based). Many changes here involve caching local variables, and/or limiting calls out to external APIs such as Netcode when possible, which all contribute to lower GC and lower execution times. All screengrabs below were taken on the min-spec Android (Samsung J2).

ClientCharacterVisualization pre:
client-char-viz-pre

ClientCharacterVisualization post:
client-char-viz-post

AnimatorFootstepSounds post:
anim-footsteps-post

ServerCharacterMovement pre:
fixedupdate-setnetworkvar-pre

ServerCharacterMovement post:
fixedupdate-setnetworkvar-post

Issue Number(s)

MTT-2471

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 4, 2022
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 4, 2022
@pdeschain pdeschain added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Apr 5, 2022
@fernando-cortez fernando-cortez merged commit 8cb5a6d into develop Apr 5, 2022
@fernando-cortez fernando-cortez deleted the fix/performance-improvements-mobile branch April 5, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

@pdeschain pdeschain

@LPLafontaineB LPLafontaineB

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @pdeschain @LPLafontaineB