feat: Added popup that tells users to set up project id if it's not set up [MTT-3265][MTT-3237] #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusted the flow slightly - if there's no project id, we block away the lobby UI and prevent attempts to authenticate (they'd cause errors and nuisance popups)
pdeschain
added
2-Easy
SamuelBellomo
added
2-Reviewed with Comments
pdeschain
added
1-Needs Review
LPLafontaineB
approved these changes
Apr 13, 2022
LPLafontaineB
added
2-One More Review
fernando-cortez
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
This resolves MTT-3237, so I'll assign that one to you @pdeschain.
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
pdeschain
changed the title
| @@ -46,6 +45,15 @@ protected override void InitializeScope() | |||
| [Inject] | |||
| async void InjectDependenciesAndInitialize(AuthenticationServiceFacade authServiceFacade, LocalLobbyUser localUser, LocalLobby localLobby) | |||
| { | |||
| #if UNITY_EDITOR | |||
| if (string.IsNullOrEmpty(UnityEditor.CloudProjectSettings.projectId)) | |||
There was a problem hiding this comment.
There's no way to check with Application.cloudProjectId? And this way it would work in builds too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added the popup that tells users to set up their project id. Also adjusted the flow slightly - if there's no project id, we block away the lobby UI and prevent attempts to authenticate (they'd cause errors and nuisance popups)
Issue Number(s)
MTT-3265
Contribution checklist