feat: other players loading progress: replacing owner-net-variables with server rpcs #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fernando Cortez <[email protected]>
* Renamed class and file to reflect naming conventions * Added namespace * Replaced magic string and const with serialized fields
This validation doesn't make sense anymore since in-scene imps are now in a different scene than the NavigationSystem
Replaced cooldown coroutine with one that unloads the scene after a delay. The coroutine is stopped in OnTriggerEnter, and before starting a new one if it wasn't stopped before.
…loading Reverted to polling to decide when to load/unload scenes instead of doing it in events to handle those intermediary states better
* Added support for non-networked game and for before the client connects
…ress bars from loading screen
* this is to handle cases where the SceneLoaderWrapper has not spawned yet (i.e. in the case of client synchronization)
…nt finishes sync before stopping loading screen Co-authored-by: Sam Bellomo <[email protected]>
LPLafontaineB
added
the
5-Design Review
LPLafontaineB
changed the title
LPLafontaineB
changed the title
| else | ||
| { | ||
| m_LocalProgress = value; | ||
| UpdateClientProgressServerRpc(NetworkManager.LocalClientId, value); |
There was a problem hiding this comment.
should extract this, shouldn't put heavy operations in properties
There was a problem hiding this comment.
need to keep track if value changed or not
There was a problem hiding this comment.
need to keep track if value changed or not
| else | ||
| { | ||
| m_LocalProgress = value; | ||
| UpdateClientProgressServerRpc(NetworkManager.LocalClientId, value); |
There was a problem hiding this comment.
should extract this, shouldn't put heavy operations in properties
|
Closing this because we decided the first solution was better |
LPLafontaineB
deleted the
feature/other-players-loading-progress-serverrpc-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR shows an alternative solution to MTT-2239, using server-authoritative network variables instead of owner-writable ones. We can decide if we prefer this solution over the other one (#580 )
Issue Number(s)
Contribution checklist