Skip to content

fix: remove initial ugs popup [MTT-3563] #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 17, 2022
Merged

fix: remove initial ugs popup [MTT-3563] #650

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
abd6d9f
renaming start buttons
LPLafontaineB May 12, 2022
09bdc56
removing initial ugs popup
LPLafontaineB May 12, 2022
339e938
Merge branch 'develop' into fix/remove-initial-ugs-popup
LPLafontaineB May 13, 2022
581c385
re-enabled UI elements in MainMenuScene
LPLafontaineB May 13, 2022
5275fe5
updated changelog
LPLafontaineB May 13, 2022
e3c13eb
Adding tooltip for UGS setup
LPLafontaineB May 13, 2022
3ff8d25
clarified changelog
LPLafontaineB May 13, 2022
c400607
Made TooltipDelay into a serialized field instead of a constant
LPLafontaineB May 13, 2022
8ae259b
set tooltip delay for UGS setup info to 0 and increased text size
LPLafontaineB May 13, 2022
9941a66
Update Assets/BossRoom/Scripts/Game/Client/UI/UITooltipDetector.cs
SamuelBellomo May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Assets/BossRoom/Scenes/MainMenu.unity
View file
Open in desktop
Git LFS file not shown
4 changes: 3 additions & 1 deletion Assets/BossRoom/Scripts/Game/Client/State/ClientMainMenuState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public class ClientMainMenuState : GameStateBehaviour
[SerializeField] Button m_LobbyButton;
[SerializeField] GameObject m_SignInSpinner;
[SerializeField] UIProfileSelector m_UIProfileSelector;
[SerializeField] UITooltipDetector m_UGSSetupTooltipDetector;

AuthenticationServiceFacade m_AuthServiceFacade;
LocalLobbyUser m_LocalUser;
Expand Down Expand Up @@ -59,7 +60,6 @@ async void InjectDependenciesAndInitialize(AuthenticationServiceFacade authServi

if (string.IsNullOrEmpty(Application.cloudProjectId))
{
PopupManager.ShowPopupPanel("Unity Gaming Services ProjectID not set up", "Click the Readme file in the Assets Folder within the Project window in-editor to follow \"How to set up Unity Gaming Services\"");
OnSignInFailed();
return;
}
Expand All @@ -85,6 +85,7 @@ async void InjectDependenciesAndInitialize(AuthenticationServiceFacade authServi
void OnAuthSignIn()
{
m_LobbyButton.interactable = true;
m_UGSSetupTooltipDetector.enabled = false;
m_SignInSpinner.SetActive(false);

Debug.Log($"Signed in. Unity Player ID {AuthenticationService.Instance.PlayerId}");
Expand All @@ -99,6 +100,7 @@ void OnSignInFailed()
if (m_LobbyButton)
{
m_LobbyButton.interactable = false;
m_UGSSetupTooltipDetector.enabled = true;
}
if (m_SignInSpinner)
{
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ feat: other players loading progress in loading screen [MTT-2239] (#580)
feat: auto reconnect [MTT-2617] (#611)

### Changed
fix: remove initial ugs popup [MTT-3563] (#650) --> Users who do not use UGS will no longer receive a popup when starting the application telling them how to set it up. It is replaced with a tooltip that appears when hovering on the "Start with Lobby" button with the cursor.
chore: bump NGO to pre.9 (#643)
chore: bump boss room to 2021 [MTT-3022] (#620)
fix: folders and assemblies refactor MTT-2623, MTT-2615 (#628)
Expand Down