Skip to content

Fix: Boss Arrow Fade In and Out [MTT-4474] #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 30, 2022
Merged

Fix: Boss Arrow Fade In and Out [MTT-4474] #715

merged 5 commits into from
Aug 30, 2022

Conversation

jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Aug 23, 2022 •
edited
Loading

Description

A quick change to make the red arrow of the boss charge effect fade in and out (rather than just popping in and out of existence)

Here's a video of the before and after!

Before:

2022-08-23.16-57-14_Trim.mp4

After:

2022-08-23.16-52-07_Trim.mp4

Issue Number(s)

Jira ticket here

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@jilfranco-unity jilfranco-unity added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 23, 2022
@jilfranco-unity jilfranco-unity changed the base branch from main to develop August 23, 2022 21:00
@SamuelBellomo
Copy link
Contributor

Fade in is very abrupt. I had to step frame by frame in your video to really see it :P cool fade out

SamuelBellomo
SamuelBellomo previously approved these changes Aug 24, 2022
View reviewed changes
LPLafontaineB
LPLafontaineB previously approved these changes Aug 24, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 25, 2022
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Aug 29, 2022
@jilfranco-unity
Merge branch 'develop' into fix/boss-arrow-fade-out
22b749f 
# Conflicts:
#	CHANGELOG.md - resolved with rider
@jilfranco-unity jilfranco-unity merged commit e11869c into develop Aug 30, 2022
@jilfranco-unity jilfranco-unity deleted the fix/boss-arrow-fade-out branch August 30, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees

@fernando-cortez fernando-cortez

@LPLafontaineB LPLafontaineB

Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilfranco-unity @SamuelBellomo @LPLafontaineB @fernando-cortez