Skip to content

feat: upgrade to NGOv1.3.1 [MTT-6243] #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

feat: upgrade to NGOv1.3.1 [MTT-6243] #828

merged 2 commits into from
Apr 25, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Apr 25, 2023 •
edited
Loading

Description

Upgrade Boss Room to Netcode for GameObjects v1.3.1.
NetworkPrefabs inside of NetworkManager have been converted to NetworkList ScriptableObject.

Issue Number(s)

MTT-6243

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 25, 2023
LPLafontaineB
LPLafontaineB approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@LPLafontaineB LPLafontaineB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include the update to Authentication, Relay, and Wire in this PR as well?

@LPLafontaineB LPLafontaineB added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 25, 2023
@fernando-cortez
Copy link
Collaborator Author

Should we also include the update to Authentication, Relay, and Wire in this PR as well?

Creating MTT-6284 as a follow up.

@fernando-cortez fernando-cortez merged commit fc27774 into develop Apr 25, 2023
@fernando-cortez fernando-cortez deleted the feat/NGOv1.3.1 branch April 25, 2023 17:28
@fernando-cortez fernando-cortez mentioned this pull request Aug 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

@LPLafontaineB LPLafontaineB

Labels
2-Easy This PR is trivial and can be reviewed quickly 2-Reviewed with Comments PR requires owner's attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernando-cortez @LPLafontaineB