Skip to content

chore: making NetworkTransform's interpolation bounds configurable. #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeffreyrainy
Copy link
Contributor

Fixes an intermittent test breakage due to extrapolation bringing us out-of-bounds
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner May 20, 2022 19:25
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffreyrainy jeffreyrainy merged commit 8a109fa into develop May 20, 2022
@jeffreyrainy jeffreyrainy deleted the chore/configurable-network-transform-interpolation-bounds branch May 20, 2022 22:08
@@ -10,6 +10,7 @@ namespace Unity.Netcode
/// </summary>
public abstract class BufferedLinearInterpolator<T> where T : struct
{
internal float MaxInterpolationBound = 3.0f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seconds? milliseconds? years? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants