Skip to content

fix: Exclude test for rising animation state count during runtime builds #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

Since the test project does not have access to the Unity.Netcode.Components internals during runtime, this PR only does this check when the integration tests are run from within the editor.

only include the GetAnimationMessage when running in the editor.
only include the animation state count check when running in the editor
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 6, 2022 20:47
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 6, 2022 20:47
removing #ifdef from NetworkAnimator.
Adding comments above the two #ifdefs' in test project.
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) October 7, 2022 17:34
@NoelStephensUnity NoelStephensUnity merged commit 4393621 into develop Oct 7, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/exclude-internal-check-runtime-for-rtt-rising-test branch October 7, 2022 18:19
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
…lds (Unity-Technologies#2241)

* test update:
only include the animation state count check when running in the editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants