fix: Refactored DeferredMessagingTests to not use coroutines and increased the slush value for the two timing-based tests... #2248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eased the slush value for the two timing-based tests... hopefully this will clear up the instability
com.unity.netcode.gameobjects/Tests/Runtime/DeferredMessagingTests.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Tests/Runtime/DeferredMessagingTests.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Tests/Runtime/DeferredMessagingTests.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return waiters; | ||
| yield return WaitForMessageReceived<T>(m_ClientNetworkManagers.ToList(), ReceiptType.Received); |
com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTest.cs
Outdated
Show resolved
Hide resolved
| @@ -64,42 +64,76 @@ public MessageHooksConditional(List<MessageHookEntry> messageHookEntries) | |||
| } | |||
| } | |||
|
|
|||
| public enum ReceiptType | |||
There was a problem hiding this comment.
😻
Love this update!
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…eased the slush value for the two timing-based tests... (Unity-Technologies#2248) * fix: Refactored DeferredMessagingTests to not use coroutines and increased the slush value for the two timing-based tests... hopefully this will clear up the instability * standards * fixed failing tests * Removed some commented-out code and left-in debug code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully this will clear up the instability.