fix: Allow empty paths in SecretsLoaderHelper #2250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a path was not provided, it would throw an exception while loading the (non-existent) file. But this will be the normal use case in live deployments, since servers and clients will have different files to load (e.g. the client will not be loading a private key).
This PR makes it so that not providing a path will just mean an empty string is used as the contents of the file. This should be functionally equivalent to not providing these values at all.
This PR also makes the paths empty by default. The previous defaults made sense in the context of the script in the test project that generates the files, but they are unlikely to be valuable to users otherwise. Not having any defaults also means we don't seem like we're taking position as to where certificates must be stored (having defaults pointing to the assets folder could have led users to think this was good or standard practice).
Changelog
N/A
Testing and Documentation