Skip to content

fix: Not sending ChangeOwnership messages to clients that have an object hidden #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 12, 2022
Merged

fix: Not sending ChangeOwnership messages to clients that have an object hidden #2251

merged 7 commits into from
Oct 12, 2022

Conversation

jeffreyrainy
Copy link
Contributor

@jeffreyrainy jeffreyrainy commented Oct 12, 2022 •
edited
Loading

This PR filters the ChangeOwnershipMessage to clients that have a given object hidden (not spawned). Addresses #2242

Changelog

Testing and Documentation

  • NetworkHideChangeOwnership test added

@jeffreyrainy jeffreyrainy requested a review from a team as a code owner October 12, 2022 14:15
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner October 12, 2022 16:01
NoelStephensUnity
NoelStephensUnity approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than optionally deleting the commented out code in the added test for this fix.
LGTM! 👍

@jeffreyrainy jeffreyrainy enabled auto-merge (squash) October 12, 2022 20:43
@jeffreyrainy jeffreyrainy merged commit 1049865 into develop Oct 12, 2022
@jeffreyrainy jeffreyrainy deleted the fix/2242-network-hide-change-ownership branch October 12, 2022 20:47
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
@jeffreyrainy @jakobbbb
fix: Not sending ChangeOwnership messages to clients that have an obj…
f9e73d4 
…ect hidden (Unity-Technologies#2251)

* fix: Not sending ChangeOwnership messages to clients that have an object hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendoyon bendoyon bendoyon approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreyrainy @bendoyon @NoelStephensUnity