fix: SceneEventProgress does not handle NetworkManager shut down during scene event #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyrainy
approved these changes
Oct 13, 2022
NoelStephensUnity
deleted the
fix/scene-event-progress-regression-bugs
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ng scene event (Unity-Technologies#2254) * fix This resolves the issue where SceneEventProgress was not checking if the NetworkManager was no longer listening or a shutdown was in progress. * update Added additional NetworkLog warning when a client times out during connection approval. * test Added a mock test to verify SceneEventProgress can handle the NetworkManager shutting down during a scene event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with
SceneEventProgressnot gracefully handling the scenario where theNetworkManagershuts down during a scene event. (regression from recent update toSceneEventProgress)Testing and Documentation