Skip to content

fix: INetworkMessageILPP failing to output registration code for network messages #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

ShadauxCat
Copy link
Collaborator

There were two issues at play here:

  1. We were looking for netstandard.dll with a simple single-layer-deep assembly reference search. In our development environments, apparently our assemblies all have it as a direct reference. In some users' environments, it's not. The search was updated to be recursive.
  2. Apparently in some environments, Type and List<> aren't even defined in netstandard.dll anyway... so I reverted those things back to importing using typeof(), which should be safe and ok for system types since they don't have any differences in structure based on conditional compilation... so netstandard.dll isn't even needed anymore, but I kept the change from part 1 because it's "more correct" anyway and will prevent us from potentially hitting any future edge cases involving assemblies that have indirect references to assemblies we need to import.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@ShadauxCat ShadauxCat requested a review from a team as a code owner October 13, 2022 22:01
@ShadauxCat
Copy link
Collaborator Author

Superseded by #2256.

@ShadauxCat ShadauxCat closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant