Skip to content

fix: in-sceneobject NetworkObject update in editor tool #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2024
Merged

fix: in-sceneobject NetworkObject update in editor tool #3084

merged 5 commits into from
Oct 10, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 2, 2024 •
edited
Loading

This resolves an issue with the in-scene network prefab instance update menu tool where it was not properly updating scenes when invoked on the root prefab instance.

MTTB-485

fix: #3067

Changelog

  • Fixed: Issue with the in-scene network prefab instance update menu tool where it was not properly updating scenes when invoked on the root prefab instance.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
32dbae3 
Update to NetworkObject to assist with the refresh in-scene prefab instances
@NoelStephensUnity
fix
948b2ed 
Fixing issue where updating a prefab used as in-scene placed prefab instance(s) would not properly get updated if the root prefab asset was updated to have a NetworkObject component.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 2, 2024 11:23
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 2, 2024 11:23
@NoelStephensUnity
style
3d7d6f8 
fixing whitespace issues.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Oct 8, 2024
Merged
@NoelStephensUnity NoelStephensUnity merged commit 25ec4a5 into develop Oct 10, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/in-sceneobject-networkobject-update-in-editor-tool branch October 10, 2024 23:39
@NoelStephensUnity NoelStephensUnity mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluong6 fluong6 fluong6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not Working: "Refresh In-Scene Prefab Instances"
2 participants
@NoelStephensUnity @fluong6