Skip to content

fix: NetworkManager instantiate & destroy notifications and player spawn prefab offset (backport) #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2024
Merged

fix: NetworkManager instantiate & destroy notifications and player spawn prefab offset (backport) #3089

merged 6 commits into from
Oct 8, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 8, 2024 •
edited
Loading

Backport of #3088

  • Provide instantiate and destroy notifications for NetworkManager
  • Fixed an issue with a recently merged PR (not yet released) where the default player prefab's position and rotation would not be used when spawning.

Changelog

  • Added: A static NetworkManager.OnInstantiated event notification to be able to track when a new NetworkManager instance has been instantiated.
  • Added: A static NetworkManager.OnDestroying event notification to be able to track when an existing NetworkManager instance is being destroyed.

Testing and Documentation

  • Includes integration test.
  • Documentation additions to public site are necessary (added to internal tracking).

@NoelStephensUnity
update
ecf8b26 
Adding NetworkManager.Instantiated and NetworkManager.Destroying event notifications.
@NoelStephensUnity
test
041b1bf 
Adding validation test.
@NoelStephensUnity
update
e1ccae4 
Adding changelog entries.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 8, 2024 18:22
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 8, 2024 18:22
@NoelStephensUnity
fix
8bb8621 
Fixing player instantiation position and rotation issue introduced in an earlier PR (but not yet released).
@NoelStephensUnity
test
5afb363 
test to validate the player spawn position fix.
adding the observers test from v2.0.0 (just good to have that in v1.x.x)
@NoelStephensUnity
style
6274c06 
remove whitespaces
@NoelStephensUnity NoelStephensUnity merged commit 8477fd4 into develop Oct 8, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkmanager-instantiatedestroy-notifications-and-playerspawn-prefab-offset-backport branch October 8, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity