Skip to content

fix: prefab processor dirty up port (up port) #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 17, 2024

This is an up-port of #3102

NetworkPrefabProcessor now marks the default NetworkPrefabsList ScriptableObject asset as dirty if there are new imports OR deletions.

The Unity Editor is now aware of the changes and able to write them to disk. This prevents the changes from being lost when the editor is quit and allows them to be tracked in version control.

Previously the script would only mark the list as dirty if there had been both new imports and deletions.

Changelog

  • Fixed: Issue where NetworkPrefabProcessor would not mark the prefab list as dirty and prevent saving the DefaultNetworkPrefabs asset when only imports or only deletes were detected.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary

NetworkPrefabProcessor now marks the default NetworkPrefabsList ScriptableObject asset as dirty if there are new imports OR deletions.
adding changelog entry
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 17, 2024 17:29
adding pr number to entry
@NoelStephensUnity NoelStephensUnity merged commit 9509696 into develop-2.0.0 Oct 17, 2024
2 of 23 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/prefab-processor-dirty-up-port branch October 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant