Skip to content

fix: Player removed from observers when player object despawns #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 24, 2024
Merged

fix: Player removed from observers when player object despawns #3110

merged 7 commits into from
Oct 24, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 23, 2024 •
edited
Loading

This PR fixes the issue where a client would be removed as an observer from all NetworkObject instances if their player object is despawned.

Changelog

  • Fixed issue where client is removed as an observer from spawned objects when their player instance is despawned.

Testing and Documentation

  • Includes PlayerSpawnAndDespawnTests integration test.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
4e52a5a 
Remove legacy observer removal code.
@NoelStephensUnity
update
c52c724 
adding change log entry.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 23, 2024 01:45
@NoelStephensUnity
fix
1c1bb2b 
Assure owner is assigned as an observer to the player.
Make sure observers are not removed from despawned players.
@NoelStephensUnity
fix
b096b06 
Make sure to take spawn with observers into account when assigning the OwnerClientId as an observer.
@NoelStephensUnity
test
942747f 
adding validation test for the fix.
@NoelStephensUnity
update
7cb4e8c 
Adding change log PR numbers to the two entries.
(left one out in PR-3108)
@NoelStephensUnity NoelStephensUnity mentioned this pull request Oct 24, 2024
Closed
@NoelStephensUnity
test-fix
91f87a4 
Fixing weird issue with the PlayerSpawnDespawn and ghost NetworkManagers.
@NoelStephensUnity NoelStephensUnity changed the title fix: Player removed from ovservers when player ojbect despawns fix: Player removed from observers when player object despawns Oct 24, 2024
@NoelStephensUnity NoelStephensUnity merged commit b64117e into develop-2.0.0 Oct 24, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/player-removed-from-ovservers-when-player-ojbect-despawns branch October 24, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity