Skip to content

fix: NetworkVariable dispose original internal #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NoelStephensUnity
Copy link
Collaborator

This just makes sure the original internal value is disposed when disposing the NetworkVariable.
(Noticed issue when backporting)

Changelog

NA

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

Assure we dispose the original internal value.
adding some comments and formatting a bit.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner November 18, 2024 18:07
@NoelStephensUnity NoelStephensUnity merged commit 72e4f20 into develop-2.0.0 Nov 18, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkvariable-dispose-original-internal branch November 18, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant