Skip to content

fix: adding extended timeout to all universal rpc tests #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: adding extended timeout to all universal rpc tests #3170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,7 @@ public void RethrowTargetInvocationException(Action action)
}
}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingNoOverride : UniversalRpcTestsBase
Expand Down Expand Up @@ -948,6 +949,7 @@ public void TestSendingNoOverride(

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSenderClientId : UniversalRpcTestsBase
Expand Down Expand Up @@ -978,6 +980,7 @@ public void TestSenderClientId(

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingNoOverrideWithParams : UniversalRpcTestsBase
Expand Down Expand Up @@ -1020,6 +1023,7 @@ public void TestSendingNoOverrideWithParams(

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingNoOverrideWithParamsAndRpcParams : UniversalRpcTestsBase
Expand Down Expand Up @@ -1062,6 +1066,7 @@ public void TestSendingNoOverrideWithParamsAndRpcParams(

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestRequireOwnership : UniversalRpcTestsBase
Expand Down Expand Up @@ -1098,6 +1103,7 @@ public void TestRequireOwnership(
}
}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestDisallowedOverride : UniversalRpcTestsBase
Expand Down Expand Up @@ -1133,6 +1139,7 @@ public void TestDisallowedOverride(

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingWithTargetOverride : UniversalRpcTestsBase
Expand Down Expand Up @@ -1166,6 +1173,7 @@ public void TestSendingWithTargetOverride(

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingWithSingleOverride : UniversalRpcTestsBase
Expand Down Expand Up @@ -1213,6 +1221,7 @@ public IEnumerator TestSendingWithSingleOverride()

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingWithSingleNotOverride : UniversalRpcTestsBase
Expand Down Expand Up @@ -1261,7 +1270,7 @@ public IEnumerator TestSendingWithSingleNotOverride()
}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSendingWithGroupOverride : UniversalRpcTestsBase
{
Expand All @@ -1288,7 +1297,6 @@ public enum AllocationType

// Extending timeout since the added yield return causes this test to commonly timeout
[Test]
[Ignore("Test Needs Refactor")]
public void TestSendingWithGroupOverride(
[Values] SendTo defaultSendTo,
[ValueSource(nameof(RecipientGroups))] ulong[] recipient,
Expand Down Expand Up @@ -1339,7 +1347,7 @@ [Values] AllocationType allocationType
}
}


[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
Expand All @@ -1366,10 +1374,9 @@ public enum AllocationType
List
}


// Extending timeout since the added yield return causes this test to commonly timeout
[Test]
[Ignore("Test Needs Refactor")]
public void TestSendingWithGroupNotOverride(
[Values] SendTo defaultSendTo,
[ValueSource(nameof(RecipientGroups))] ulong[] recipient,
Expand Down Expand Up @@ -1420,6 +1427,7 @@ [Values] AllocationType allocationType
}
}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestDefaultSendToSpecifiedInParamsSendingToServerAndOwner : UniversalRpcTestsBase
Expand All @@ -1430,6 +1438,7 @@ public UniversalRpcTestDefaultSendToSpecifiedInParamsSendingToServerAndOwner(Hos
}
}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestDeferLocal : UniversalRpcTestsBase
Expand Down Expand Up @@ -1617,6 +1626,7 @@ public IEnumerator TestDeferLocalOverrideToFalse()

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestMutualRecursion : UniversalRpcTestsBase
Expand Down Expand Up @@ -1666,6 +1676,7 @@ public void TestMutualRecursion()

}

[Timeout(1200000)]
[TestFixture(HostOrServer.Host)]
[TestFixture(HostOrServer.Server)]
internal class UniversalRpcTestSelfRecursion : UniversalRpcTestsBase
Expand Down Expand Up @@ -1705,6 +1716,7 @@ public void TestSelfRecursion()

}

[Timeout(1200000)]
[TestFixture(ObjType.Server)]
[TestFixture(ObjType.Client)]
internal class UniversalRpcTestRpcTargetUse : UniversalRpcTestsBase
Expand Down