ci: [Backport] NGO CI update and rewrite [1.X] (#3193) #3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor of CI setup, jobs and triggers * Disabling some tests which failing on mobile devices * Setting up Renovate bot configuration (same as already present in develop branch) * Added pvpExceptions file --------- Co-authored-by: NoelStephensUnity <[email protected]>
michalChrobot
requested review from
chrispope,
miniwolf,
NoelStephensUnity,
fluong6 and
a team
as code owners
…orkConnection)' is obsolete: 'RemoteEndPoint has been renamed to GetRemoteEndpoint. (UnityUpgradable) -> GetRemoteEndpoint(*)'"
NoelStephensUnity
changed the title
…int(NetworkConnection)' is obsolete: 'RemoteEndPoint has been renamed to GetRemoteEndpoint. (UnityUpgradable) -> GetRemoteEndpoint(*)'"" This reverts commit 7ccdd89.
…-Technologies/com.unity.netcode.gameobjects into NGO-CI-rewrite-for-develop
This resolves the trunk failures due to updates in collections.
NoelStephensUnity
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Looks like it should be good to go at this point!
Thank you @michalChrobot for all of the time and patience on this PR!
🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #3193 and aims to include
Notable difference is that manifest lists more editors since develop supports editors from 2021.3 (in contrast to develop-2.0.0 which supports from 6000.0)
Resolved:
Another change worth noticing is a fix for Standards fail within NGO package which states:
[14:08:00.316 Information] /home/bokken/build/output/Unity-Technologies/com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs(1236,28): error CS0618: 'NetworkDriver.RemoteEndPoint(NetworkConnection)' is obsolete: 'RemoteEndPoint has been renamed to GetRemoteEndpoint. (UnityUpgradable) -> GetRemoteEndpoint(*)'