Skip to content

ci: Added tracking information to ignored tests #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

ci: Added tracking information to ignored tests #3308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c75796
Added tracking informations to ignored tests
michalChrobot Feb 19, 2025
b1bf3d7
Merge branch 'develop-2.0.0' into disabled-tests-move-to-jira
michalChrobot Feb 20, 2025
138ad6d
Merge branch 'develop-2.0.0' into disabled-tests-move-to-jira
EmandM Feb 21, 2025
2cf209c
Merge branch 'develop-2.0.0' into disabled-tests-move-to-jira
michalChrobot Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions com.unity.netcode.gameobjects/Tests/Editor/InterpolatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public void OutOfOrderShouldStillWork()
Assert.That(interpolator.GetInterpolatedValue(), Is.EqualTo(2f).Within(k_Precision));
}

[Ignore("TODO: Fix this test to still handle testing message loss without extrapolation")]
[Ignore("TODO: Fix this test to still handle testing message loss without extrapolation. This is tracked in MTT-11338")]
[Test]
public void MessageLoss()
{
Expand Down Expand Up @@ -306,7 +306,7 @@ public void TestUpdatingInterpolatorWithNoData()
Assert.Throws<InvalidOperationException>(() => interpolator.Update(1f, serverTime));
}

[Ignore("TODO: Fix this test to still test duplicated values without extrapolation")]
[Ignore("TODO: Fix this test to still test duplicated values without extrapolation. This is tracked in MTT-11338")]
[Test]
public void TestDuplicatedValues()
{
Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal class NetworkMetricsRegistrationTests
.ToArray();

[TestCaseSource(nameof(s_MetricTypes))]
[Ignore("Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI.")]
[Ignore("Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. This ignored test is tracked in MTT-11339")]
public void ValidateThatAllMetricTypesAreRegistered(Type metricType)
{
var dispatcher = new NetworkMetrics().Dispatcher as MetricDispatcher;
Expand Down
1 change: 0 additions & 1 deletion com.unity.netcode.gameobjects/Tests/Runtime/DeferredMessagingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ public void WhenANetworkVariableDeltaMessageArrivesBeforeASpawnArrives_ItIsDefer
}

[Test]
//[Ignore("Disabling this temporarily until it is migrated into new integration test.")]
public void WhenASpawnMessageArrivesBeforeThePrefabIsAvailable_ItIsDeferred()
{
m_SkipAddingPrefabsToClient = true;
Expand Down
3 changes: 1 addition & 2 deletions com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransformAnticipationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ public AnticipatedNetworkTransform GetOtherClientComponent()
}

[Test]
// I will add this test to track in Jira as next step (after having working CI in place). The job is failing on Android
[UnityPlatform(exclude = new[] { RuntimePlatform.Android })]
[UnityPlatform(exclude = new[] { RuntimePlatform.Android })] // TODO: this ignored test is tracked in MTT-11341
public void WhenAnticipating_ValueChangesImmediately()
{
var testComponent = GetTestComponent();
Expand Down
8 changes: 4 additions & 4 deletions com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2159,7 +2159,7 @@ public string ArrayStr<T>(NativeArray<T> arr) where T : unmanaged
}

[Test]
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is failing on iOS
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
[Repeat(5)]
public void WhenSerializingAndDeserializingVeryLargeValueTypeNativeArrayNetworkVariables_ValuesAreSerializedCorrectly(

Expand Down Expand Up @@ -2613,7 +2613,7 @@ public string DictionaryStr<TKey, TVal>(Dictionary<TKey, TVal> list)
}

[Test]
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is failing on iOS
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
[Repeat(5)]
public void WhenSerializingAndDeserializingVeryLargeListNetworkVariables_ValuesAreSerializedCorrectly(

Expand Down Expand Up @@ -2800,7 +2800,7 @@ public void WhenSerializingAndDeserializingVeryLargeListNetworkVariables_ValuesA
}

[Test]
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is failing on iOS
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
[Repeat(5)]
public void WhenSerializingAndDeserializingVeryLargeHashSetNetworkVariables_ValuesAreSerializedCorrectly(

Expand Down Expand Up @@ -2956,7 +2956,7 @@ public void WhenSerializingAndDeserializingVeryLargeHashSetNetworkVariables_Valu
}

[Test]
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // I will add this test to track in Jira as next step (after having working CI in place). The job is unstable on mobile devices
[UnityPlatform(exclude = new[] { RuntimePlatform.Android, RuntimePlatform.IPhonePlayer })] // Ignored test tracked in MTT-11343
[Repeat(5)]
public void WhenSerializingAndDeserializingVeryLargeDictionaryNetworkVariables_ValuesAreSerializedCorrectly(

Expand Down